Review main Merged

64456[TASK] Don't use GeneralUtility::getContainer in functional tests

Benjamin Franzke CR +2 V +2 Normal +99 −109 updated 05/13/20, 06:26

Commit message

As GeneralUtility::getContainer is marked internal, we do now avoid
to use this method in core tests in order to demonstrate best
practices for third party extensions that may use core tests as
inspiration.

This change requires an update for typo3/testing-framework which now
provides a getContainer() method as API in functional tests:

  composer require --dev typo3/testing-framework:^6.2.5

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 710

  1. Benjamin Franzke uploaded patch set 1 05/11/20, 19:05

  2. TYPO3com voted on patch set 1 V -1 05/11/20, 19:17 Completed build in 11m 42s on Mon, 11 May, 07:17 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3308

  3. Benjamin Franzke uploaded patch set 2 05/11/20, 19:25

  4. TYPO3com voted on patch set 2 V +1 05/11/20, 19:41 Completed build in 15m 59s on Mon, 11 May, 07:41 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3310

  5. Benjamin Franzke uploaded patch set 3 05/12/20, 16:14

  6. TYPO3com voted on patch set 3 V +1 05/12/20, 16:26 Completed build in 12m 06s on Tue, 12 May, 04:26 PM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3343

  7. Benni Mack voted on patch set 3 V +1 CR +1 05/12/20, 16:38

  8. Susi Moog voted on patch set 3 V +1 CR +1 05/13/20, 06:24

  9. Benni Mack voted on patch set 3 V +2 CR +2 05/13/20, 06:26

  10. Benni Mack merged patch set 4 05/13/20, 06:26