Review 9.5 Merged

64458[TASK] Integrate server response security checks

Oliver Hader CR +2 V +2 Hard +564 −1 updated 05/12/20, 09:07

Commit message

In order to evaluate potential server misconfigurations and to reduce
the potential of security implications in general, a new HTTP response
check is integrated to "Environment Status" and the "Security" section
in the reports module.

It is evaluated whether non-standard file extensions lead to unexpected
handling on the server-side, such as `test.php.wrong` being evaluated
as PHP or `test.html.wrong` being served with `text/html` content type.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 812

  1. Oliver Hader uploaded patch set 1 05/11/20, 22:06

  2. TYPO3com voted on patch set 1 V -1 05/11/20, 22:06 Completed build in 21s on Mon, 11 May, 10:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-591

  3. Oliver Hader uploaded patch set 2 05/11/20, 22:08

  4. TYPO3com voted on patch set 2 V +1 05/11/20, 22:21 Completed build in 12m 09s on Mon, 11 May, 10:21 PM Test Summary: 74870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-592

  5. Josef Glatz commented on patch set 2 05/12/20, 03:12

    Feature-91354-IntegrateServerResponseSecurityChecks.rst:27

    Is it intended to link to the 10.4 guide in the 9.5 branch?
  6. Oliver Hader commented on patch set 3 05/12/20, 07:26

    Published edit on patch set 2.
  7. Oliver Hader commented on patch set 3 05/12/20, 07:28

    Feature-91354-IntegrateServerResponseSecurityChecks.rst:27 Reply Unresolved

    Yes... that's most recent... actually the security guide is valid for all versions in general... that was not considered when it has been merged from a standalone documentation into Core API docs. I currently don't know how to solve that in a general way...
  8. TYPO3com voted on patch set 3 V +1 05/12/20, 07:56 Completed build in 27m 03s on Tue, 12 May, 07:56 AM Test Summary: 74870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-596

  9. Oliver Hader uploaded patch set 4 05/12/20, 08:28

  10. TYPO3com voted on patch set 4 V +1 05/12/20, 08:56 Completed build in 23m 58s on Tue, 12 May, 08:56 AM Test Summary: 74870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-599

  11. Oliver Hader voted on patch set 4 V +2 CR +2 05/12/20, 09:07

  12. Oliver Hader merged patch set 5 05/12/20, 09:07