Review main Merged

64470[SECURITY] Mitigate bypassing CSRF token via XSS

Oliver Hader CR +2 V +2 Hard +354 −6 updated 05/13/20, 13:44

Commit message

Cross-site scripting in same-site/same-origin context most probably
allows bypassing tokens that usually protects against cross-site
request forgery - basically that is obvious when focusing on
"cross-site" and "same-site" terminology.

To mitigate these scenarios, same-site requests from outside`/typo3/`
URI path - which is used to access the backend user interface - now
have to provide an HTTP `Referer` header which is enforced for global
routes potentially containing CSRF tokens.

In general all routes that switch their state internally from
`public` to `restricted` are relevant in this scenario. If really
necessary, the behavior can be disabled using corresponding feature
switch `security.backend.enforceReferrer` in TYPO3_CONF_VARS.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 20

Review log 45

  1. Oliver Hader uploaded patch set 1 05/12/20, 09:22

  2. Oliver Hader commented on patch set 1 V +2 CR +2 05/12/20, 09:22

    Auto-approved
  3. Oliver Hader merged patch set 2 05/12/20, 09:22

  4. TYPO3com voted on patch set 1 V +1 05/12/20, 10:31 Completed build in 2h 04m 29s on Tue, 12 May, 10:31 AM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3332

  5. Oliver Hader commented on patch set 2 05/13/20, 13:44

    Login.ts:117 Unresolved

    It might happen, that this element is not available → see https://forge.typo3.org/issues/91385