Review main Merged

64476[BUGFIX] Make edit record bookmarks appear again

Helmut Hummel CR +2 V +2 Easy +2 −1 updated 08/22/20, 09:04

Commit message

The patch for issue #91210 introduced a side effect that bookmarks
to controllers which are not directly registered as backend modules
do not show up again because the ModuleLoader->checkMod() call does
not return an array anymore.
Bookmarks to records of FormEngine / EditDocumentController
are affected by this and are simply not rendered as bookmark
toolbar items.
The patch applies a hack to the ShortcutRepository to deal with
this. We need a better module / controller access API substituting
TBE_MODULES to deal with this properly. EditDocumentController
does it's own access checks for records, so the patch shouldn't
add security harm.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1319

  1. Helmut Hummel uploaded patch set 1 05/12/20, 15:10

  2. Helmut Hummel commented on patch set 1 05/12/20, 15:12

    This change is ready for review.

    ModuleLoader.php:147 Unresolved

    not intended as "real" fix, but a first hack to demonstrate the culprit

    ext_tables.php:52 Unresolved

    that is an alternative hack to fix the bug
  3. Helmut Hummel uploaded patch set 2 05/12/20, 15:12

  4. TYPO3com voted on patch set 1 V +1 05/12/20, 15:22 Completed build in 11m 46s on Tue, 12 May, 03:22 PM Test Summary: 73707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3339

  5. Tymoteusz Motylewski commented on patch set 2 05/12/20, 15:23

    This change is ready for review.

    ext_tables.php:52

    debug leftover?
  6. TYPO3com commented on patch set 2 05/12/20, 15:27 Completed build in 15m 08s on Tue, 12 May, 03:27 PM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3340

  7. Helmut Hummel commented on patch set 2 05/12/20, 15:51

    ext_tables.php:52 Reply Unresolved

    See my comment on patch set 1
  8. Andreas Kießling commented on patch set 2 V +1 08/04/20, 14:08

    Any news on that issue? Would be nice to get the bookmarks working again. Both approaches do the job, but as Helmut already stated are more a hack than a real fix.
  9. Christian Kuhn uploaded patch set 3 08/21/20, 19:22

  10. TYPO3com voted on patch set 3 V +1 08/21/20, 19:34 Completed build in 11m 19s on Fri, 21 Aug, 07:34 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4826

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 08/21/20, 19:40

  12. Helmut Hummel voted on patch set 3 V +1 CR +1 08/21/20, 19:48

  13. Wolfgang Wagner uploaded patch set 4 08/22/20, 07:23

  14. Wolfgang Wagner uploaded patch set 5 08/22/20, 07:24

  15. TYPO3com voted on patch set 4 V -1 08/22/20, 07:46 Completed build in 21m 54s on Sat, 22 Aug, 07:46 AM Test Summary: 12 of 73364 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4838

  16. TYPO3com commented on patch set 5 08/22/20, 07:59 Completed build in 34m 45s on Sat, 22 Aug, 07:59 AM Test Summary: 72037 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4839

  17. Andreas Kienast voted on patch set 5 V +2 CR +2 08/22/20, 08:57

  18. TYPO3com voted on patch set 5 V +1 08/22/20, 09:02 Completed build in 2h 12m 28s on Sat, 22 Aug, 09:02 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4839

  19. Andreas Kienast merged patch set 6 08/22/20, 09:04