64479[BUGFIX] Use correctly terminated HTML block elements
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Daniel Goerz +1
- Susi Moog +1
- Helmut Hummel +1
-
Verified V +2 Done
- Oliver Hader +2
- Sebastien Convers +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 17
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CheckboxEditor.html+2 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CollectionElementHeaderEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FinishersEditor.html+2 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/GridColumnViewPortConfigurationEditor.html+3 −3
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/MaximumFileSizeEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/MultiSelectEditor.html+2 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/PropertyGridEditor.html+4 −4
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/RequiredValidatorEditor.html+3 −3
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/SingleSelectEditor.html+2 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextareaEditor.html+3 −3
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextEditor.html+3 −3
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/Typo3WinBrowserEditor.html+5 −5
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidationErrorMessageEditor.html+2 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidatorsEditor.html+2 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/ContentElement.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/FileUploadTemplate.html+2 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/StaticText.html+1 −1
Review log 1314
-
Oliver Hader uploaded patch set 1 05/12/20, 20:14
-
TYPO3com voted on patch set 1 V +1 05/12/20, 20:32 Completed build in 17m 14s on Tue, 12 May, 08:32 PM Test Summary: 73707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3347
-
Daniel Goerz voted on patch set 1 CR +1 05/12/20, 21:16
-
Susi Moog voted on patch set 1 V +1 CR +1 05/13/20, 05:09
-
Andreas Kienast commented on patch set 1 05/13/20, 06:07
How did you find these occurrences? We might have that issue in other areas as well (especially in the backports). -
Oliver Hader commented on patch set 1 05/13/20, 07:48
It's impossible to directly search for that... previously I was checking the sources for occurrences like `<div /><div />` (with RegExp) - which did not work here since those changes are * multiline * not related to a JavaScript context in the first place * actually "valid" in a pure XML approach (without having HTML ns/DTD) Thus, I found those templates by debugging through ext:form JavaScript application. -
Benjamin Franzke commented on patch set 1 05/13/20, 09:23
We can try to search for problems using: git grep "<\(div\|p\|span\|ul\|ol\) [^>]*/>" | grep -v "Resources/Public/JavaScript/.*\.js:define(" But yes, as Olli said, not everything is necessarily processed by jQuery. For a first approximation you can try limit the regex to direct jQuery usages: git grep "\(jQuery\|[$]\).*<\(div\|p\|span\|ul\|ol\) [^>]*/>" | grep -v "Resources/Public/JavaScript/.*\.js:define(" -
Sebastien Convers commented on patch set 1 V +1 05/14/20, 09:52
Thanks for the patch, i tried it on 10.4.2, it fix https://forge.typo3.org/issues/91379 and https://forge.typo3.org/issues/91367. (sorry if i'm doing something wrong, first time i'm using Gerrit!) -
Helmut Hummel voted on patch set 1 CR +1 05/14/20, 11:07
-
Oliver Hader commented on patch set 1 05/14/20, 11:52
> Patch Set 1: Verified+1 > > Thanks for the patch, i tried it on 10.4.2, it fix https://forge.typo3.org/issues/91379 and https://forge.typo3.org/issues/91367. > (sorry if i'm doing something wrong, first time i'm using Gerrit!) Thanks you Sebastien, your review vote is perfect! Thx! -
Oliver Hader voted on patch set 1 CR -1 05/14/20, 15:29
-
Oliver Hader voted on patch set 1 CR 0 05/14/20, 15:37
-
Oliver Hader voted on patch set 1 V +2 CR +2 05/14/20, 17:58
-
Oliver Hader merged patch set 2 05/14/20, 17:58