Review main Abandoned

64480[TASK] Update .gitattributes to respect files in ckeditor4 package sources

Josef Glatz CR 0 V 0 Easy +3 −0 updated 05/13/20, 03:40

Commit message

This patch adds the proper lines to .gitattributes for
the ckeditor4 package to remove the changed files
in your working copy after running the command:

    cd Build && nvm use && yarn && yarn build

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Josef Glatz uploaded patch set 1 05/12/20, 21:10

  2. Josef Glatz commented on patch set 1 05/12/20, 21:12

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 05/12/20, 21:52 Completed build in 15m 50s on Tue, 12 May, 09:52 PM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3355

  4. Benjamin Franzke commented on patch set 1 V -1 CR -1 05/12/20, 22:44

    Thanks for the patch, I agree that we should make make this more developer friendly, especially to declobber the `git status` output. But, after running `yarn build`, `git status` still shows all the css,js and txt files as changed for me. (Because the new CRLF sources still differ from the LF versions that are currently stored in the git index) Event `git diff` still shows eleven md/html files, because those two suffixes would need to be added to gitattributes as well. But anyway, this change would now mean that a git-checkout of TYPO3 (or even the zip/tar package) would contain these sources as CRLF, while they are still stored as LF in the index. Anyway(2), I would actually prefer to keep using proper Unix Line Feeds for all plaintext files, without Carriage Return. Therefore I vote for adapting the grunt copy-pipeline to convert these files to LF. Please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/64481 for my proposal.
  5. Josef Glatz commented on patch set 1 V -1 CR -1 05/13/20, 03:40

  6. Josef Glatz abandoned the change 05/13/20, 03:40