Review 9.5 Merged

64483[BUGFIX] Fix "see also" links in CSH entries

Josef Glatz CR +2 V +2 Normal +51 −46 updated 05/14/20, 04:24

Commit message

The "see also" links, used for cross referencing
different CSH entries are fixed. Cross referencing
links are now built using the proper ViewHelper.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 89

  1. Josef Glatz uploaded patch set 1 05/13/20, 14:18

  2. Josef Glatz commented on patch set 1 05/13/20, 14:22

    In 9.5 only the cross links are broken. This is the reason why a new Change-Id was introduced next to Daniel's patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/64477 PRETTY EASY TO TEST: * Open a CSH entry with a "see also" link section at the bottom * click on any internal see also link * without this patch a TOC is shown * with this patch the right page is shown
  3. Josef Glatz wrote 05/13/20, 14:22

    Topic set to csh
  4. Daniel Siepmann voted on patch set 1 CR +1 05/13/20, 14:26

  5. TYPO3com voted on patch set 1 V +1 05/13/20, 14:30 Completed build in 12m 04s on Wed, 13 May, 02:30 PM Test Summary: 74873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-607

  6. Daniel Siepmann voted on patch set 1 V +1 05/13/20, 14:37

  7. Oli Bartsch voted on patch set 1 V +1 CR +1 05/13/20, 14:45

  8. Georg Ringer voted on patch set 1 V +2 CR +2 05/14/20, 04:24

  9. Georg Ringer merged patch set 2 05/14/20, 04:24