Review main Merged

64489[BUGFIX] Fix serialization of ObjectManager

Benjamin Franzke CR +2 V +2 Easy +2 −6 updated 05/18/20, 15:17

Commit message

The PSR-11 container instance was not cleared upon serialization which
caused an exception when Closures in the container where tried to be
serialized.

__wakeup() does already contain code to reset the container instance,
therefore we only need to clear the entire object manager properties
in __sleep().

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Alexander Schnitzler +1
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 913

  1. Benjamin Franzke uploaded patch set 1 05/14/20, 11:16

  2. TYPO3com voted on patch set 1 V -1 05/14/20, 11:30 Completed build in 13m 31s on Thu, 14 May, 11:30 AM Test Summary: 72778 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3375

  3. TYPO3com commented on patch set 1 05/14/20, 11:54 Completed build in 13m 18s on Thu, 14 May, 11:54 AM Test Summary: 1 of 74210 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3376

  4. TYPO3com voted on patch set 1 V +1 05/14/20, 21:04 Completed build in 12m 07s on Thu, 14 May, 09:04 PM Test Summary: 73726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3384

  5. Alexander Schnitzler commented on patch set 1 05/15/20, 07:03

    ObjectManager.php:70

    What about returning an empty array here instead since there are no properties left to serialize anyway.
  6. Benjamin Franzke uploaded patch set 2 1 comment 05/15/20, 07:22

  7. TYPO3com voted on patch set 2 V +1 05/15/20, 07:34 Completed build in 12m 14s on Fri, 15 May, 07:34 AM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3385

  8. Alexander Schnitzler voted on patch set 2 V +1 CR +1 05/15/20, 13:09

  9. Andreas Kienast voted on patch set 2 CR +1 05/18/20, 10:46

  10. Oliver Hader commented on patch set 2 CR +1 05/18/20, 10:52

    Nice one!
  11. Susi Moog voted on patch set 2 CR +1 05/18/20, 11:36

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 05/18/20, 15:17

  13. Andreas Kienast merged patch set 3 05/18/20, 15:17