Review main Merged

64490[BUGFIX] Fix SMTP encryption migration when plaintext was used before

Benjamin Franzke CR +2 V +2 Easy +3 −1 updated 05/14/20, 18:34

Commit message

The SMTP SSL/TLS migration introduced in #91070 does not take the case
into account when no SMTP encryption was used at all (that means insecure
plaintext authentication). This could be configured by specifying an empty
string for `transport_smtp_encrypt` in TYPO3 v9.

We do now check for this third option and adapt the migration
to set the value to false, which means symfony/mailer will allow
connection without encryption. Note: symfony/mailer will still try to
start a STARTTLS connection if the server supports that capability.
(That is now default in symfony/mailer and can't be deactivated)

We also fix the default configuration of transport_smtp_encrypt
to be a boolean value. The setting was switched to boolean in #90295
but was forgotten to be adapted here.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • Torben Hansen +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 68

  1. Benjamin Franzke uploaded patch set 1 05/14/20, 12:22

  2. Josef Glatz voted on patch set 1 CR +1 05/14/20, 12:36

  3. TYPO3com voted on patch set 1 V -1 05/14/20, 12:37 Completed build in 14m 00s on Thu, 14 May, 12:37 PM Test Summary: 2 of 74211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3377

  4. TYPO3com voted on patch set 1 V +1 05/14/20, 17:07 Completed build in 12m 06s on Thu, 14 May, 05:07 PM Test Summary: 73726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3381

  5. Josef Glatz voted on patch set 1 V +1 05/14/20, 17:23

  6. Torben Hansen voted on patch set 1 V +1 CR +1 05/14/20, 18:17

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 05/14/20, 18:34

  8. Benjamin Franzke merged patch set 2 05/14/20, 18:34