Review 9.5 Merged

64491[BUGFIX] Make "showHiddenRecords" in adminpanel work again

Christian Eßl CR +2 V +2 Easy +0 −1 updated 08/10/20, 13:57

Commit message

The Backport of #86653 to 9.5 introduced a regression that made it
impossible to preview hidden content via adminpanel in the frontend,
when the option "Show hidden records" is used.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Tomas Norre Mikkelsen +1
    • Daniel Haupt +1
    • Markus Gehrig +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 2427

Show 12 earlier messages
  1. Christian Eßl uploaded patch set 1 05/14/20, 12:23

  2. TYPO3com voted on patch set 1 V +1 05/14/20, 12:42 Completed build in 17m 30s on Thu, 14 May, 12:41 PM Test Summary: 74873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-612

  1. Susi Moog commented on patch set 1 05/18/20, 11:36

    I'm not quite sure why I added that, cases that should work (which may be impacted by this change): - Backend preview links with time / user group restrictions - Backend preview links with restrictions should set AdminPanel settings accordingly - AdminPanel settings should have lower priority than backend preview settings
  2. Markus Klösges commented on patch set 1 V +1 CR +1 05/26/20, 14:30

    Can confirm bug and that this patch fixes the issue
  3. Chris Müller commented on patch set 1 V -1 05/27/20, 05:16

    With this patch the displaying of hidden records works, but they are only shown when manually Shift+Reload the page. So: Activate the Admin Panel (the "Show hidden records" option is already enabled) => no hidden records shown Shift+Reload the page => hidden records are shown Deactivate the Admin Panel => hidden records are shown Shift+Reload the page => hidden records not shown Also when enabling/disabling the checkboxes.
  4. Rémy DANIEL commented on patch set 1 06/04/20, 13:25

    > Patch Set 1: > > I'm not quite sure why I added that, cases that should work (which may be impacted by this change): > > - Backend preview links with time / user group restrictions > - Backend preview links with restrictions should set AdminPanel settings accordingly > - AdminPanel settings should have lower priority than backend preview settings Susy, your commit message on https://review.typo3.org/c/Packages/TYPO3.CMS/+/59927 explains the why isn't it?
  5. Tomas Norre Mikkelsen voted on patch set 1 CR +1 06/05/20, 08:22

  6. Felix Kopp commented on patch set 1 V +1 CR +1 06/10/20, 07:24

    Should have been shipped with bugfix release yesterday.
  7. Rémy DANIEL commented on patch set 1 CR -1 06/10/20, 08:16

    I would not merge this before getting Susy's feedback. Personally I think the issue is more a Middleware priority issue (the admin panel's should run after the frontend's)
  8. Felix Kopp commented on patch set 1 06/10/20, 09:13

    > Patch Set 1: Code-Review-1 > > I would not merge this before getting Susy's feedback. > Personally I think the issue is more a Middleware priority issue (the admin panel's should run after the frontend's) @susy which support do you need to resolve this issue?
  9. Felix Kopp commented on patch set 1 07/02/20, 15:50

    > Patch Set 1: > > > Patch Set 1: Code-Review-1 > > > > I would not merge this before getting Susy's feedback. > > Personally I think the issue is more a Middleware priority issue (the admin panel's should run after the frontend's) > > @susy which support do you need to resolve this issue? What is the status? This issue is a heavy weight problem for a CMS. Since content can not be managed when hidden.
  10. Susi Moog commented on patch set 1 07/03/20, 07:19

    Please handle the issue without me, I will not have the opportunity to get involved in due time and it should not wait for me.
  11. Felix Kopp commented on patch set 1 07/29/20, 13:34

    Chris Müller, why are you still blocking?
  12. Chris Müller wrote 07/29/20, 17:51

    Removed Verified-1 by Chris Müller <typo3@krue.ml>
  13. Benni Mack commented on patch set 1 08/05/20, 15:22

    @Remy DANIEL can you recheck the change please?
  14. Rémy DANIEL wrote 08/05/20, 20:31

    Removed Code-Review-1 by Rémy DANIEL <dogawaf@no-log.org>
  15. Rémy DANIEL commented on patch set 1 08/05/20, 20:32

    I removed my vote, I have no time currently to re-check the change, sorry.
  16. Christian Kuhn commented on patch set 1 08/06/20, 08:27

    misses Releases: line
  17. Helmut Hummel updated the commit message in patch set 2 08/06/20, 09:29

  18. Helmut Hummel commented on patch set 2 08/06/20, 09:31

    Reply

    Done
  19. TYPO3com voted on patch set 2 V -1 08/06/20, 09:41 Completed build in 11m 59s on Thu, 6 Aug, 09:41 AM Test Summary: 75068 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-746

  20. TYPO3com voted on patch set 2 V +1 08/07/20, 11:04 Completed build in 1h 46m 36s on Fri, 7 Aug, 11:04 AM Test Summary: 75139 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-746

  21. Daniel Haupt voted on patch set 2 V +1 CR +1 08/09/20, 19:09

  22. Tomas Norre Mikkelsen voted on patch set 2 CR +1 08/10/20, 08:12

  23. Markus Gehrig voted on patch set 2 CR +1 08/10/20, 13:26

  24. Benni Mack voted on patch set 2 V +2 CR +2 08/10/20, 13:57

  25. Benni Mack merged patch set 3 08/10/20, 13:57