64492[BUGFIX] Allow multiple referrer types in backend main route
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Susi Moog +1
-
Verified V +2 Done
- Richard Haeser +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2023
-
Oliver Hader uploaded patch set 1 05/14/20, 15:04
-
TYPO3com voted on patch set 1 V +1 05/14/20, 15:15 Completed build in 11m 28s on Thu, 14 May, 03:15 PM Test Summary: 73780 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3378
-
Markus Klein updated the commit message in patch set 2 05/14/20, 15:25
-
TYPO3com voted on patch set 2 V +1 05/14/20, 15:37 Completed build in 12m 53s on Thu, 14 May, 03:37 PM Test Summary: 73780 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3380
-
Oliver Hader commented on patch set 2 05/15/20, 08:40
When testing, please make sure clear route caches (either "clear all caches" or "typo3temp/var/cache/") -
Susi Moog commented on patch set 2 05/15/20, 09:30
ReferrerEnforcer.php:72should we add additional braces here? from reading alone I'm not sure whether that's meant as || ... whole line or || ( ... ) && ( .. ) || (... -
Susi Moog commented on patch set 2 05/15/20, 09:56
ReferrerEnforcerTest.php:58and is "exmaple" on purpose or by accident? ;) -
David Rellstab voted on patch set 2 CR +1 05/15/20, 10:00
-
Susi Moog voted on patch set 2 V +1 CR +1 05/15/20, 11:16
-
Susi Moog commented on patch set 2 05/15/20, 11:16
aside from the "readability remarks" it's working as expected. -
Oliver Hader commented on patch set 2 05/15/20, 11:19
ReferrerEnforcer.php:72Reply UnresolvedI'm fine with adding braces here - see https://www.php.net/manual/en/language.operators.precedence.php `($referrerType & self::TYPE_REFERRER_EMPTY && in_array('refresh-empty', $flags, true))` -
Riny van Tiggelen voted on patch set 2 V +1 05/15/20, 12:08
-
Richard Vollebregt commented on patch set 2 CR +1 05/15/20, 12:08
> Patch Set 2: > > (1 comment) -
Richard Vollebregt wrote 05/15/20, 12:08
Removed Code-Review+1 by Richard Vollebregt <richard.vollebregt@maxserv.com> -
Richard Vollebregt voted on patch set 2 V +1 05/15/20, 12:09
-
Susi Moog commented on patch set 2 CR -1 05/15/20, 13:35
will add the braces and correct the typo - just a minute :) -
Susi Moog uploaded patch set 3 05/15/20, 13:37
-
Susi Moog voted on patch set 3 V +1 CR +1 05/15/20, 13:38
-
Richard Haeser voted on patch set 3 V +1 CR +1 05/15/20, 13:40
-
Oliver Hader commented on patch set 3 05/15/20, 13:48
ReferrerEnforcerTest.php:58Reply UnresolvedAccident... should be "example", but in since I copied it correctly, the tests are at least correct ;-) -
TYPO3com voted on patch set 3 V +1 05/15/20, 13:53 Completed build in 15m 40s on Fri, 15 May, 01:53 PM Test Summary: 73781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3394
-
Richard Haeser voted on patch set 3 V +2 CR +2 05/18/20, 08:09
-
Richard Haeser merged patch set 4 05/18/20, 08:09