Review 9.5 Merged

64495[BUGFIX] Set changed state of FormEngine when null placeholder fields are changed

Andreas Kienast CR +2 V +2 Normal +87 −0 updated 05/15/20, 13:15

Commit message

When a null placeholder checkbox is changed, the linked form field is
now marked as "changed", which triggers the confirmation when leaving
the form while being unsaved.

Review

  • Code review CR +2 Done
    • Susi Moog +2
  • Verified V +2 Done
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 58

  1. Andreas Kienast uploaded patch set 1 05/15/20, 06:26

  2. TYPO3com voted on patch set 1 V -1 05/15/20, 06:26 Completed build in 33s on Fri, 15 May, 06:26 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-614

  3. Andreas Kienast uploaded patch set 2 05/15/20, 06:37

  4. TYPO3com voted on patch set 2 V -1 05/15/20, 06:50 Completed build in 13m 11s on Fri, 15 May, 06:50 AM Test Summary: 1 of 75493 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-615

  5. Andreas Kienast uploaded patch set 3 05/15/20, 07:04

  6. TYPO3com voted on patch set 3 V +1 05/15/20, 07:16 Completed build in 11m 47s on Fri, 15 May, 07:16 AM Test Summary: 74893 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-616

  7. Susi Moog voted on patch set 3 V +2 CR +2 05/15/20, 13:15

  8. Susi Moog merged patch set 4 05/15/20, 13:15