64501[BUGFIX] Allow arbitrary objects in widget context
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Alexander Schnitzler +1
- Susi Moog +1
-
Verified V +2 Done
- Andreas Kienast +2
- Alexander Schnitzler +1
- Jonas Götze +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2128
Show 23 earlier messages
-
Oliver Hader uploaded patch set 1 05/16/20, 10:13
-
TYPO3com voted on patch set 1 V +1 05/16/20, 10:29 Completed build in 15m 53s on Sat, 16 May, 10:29 AM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3400
-
Oliver Hader uploaded patch set 2 05/16/20, 10:34
-
Helmut Hummel voted on patch set 2 CR +1 05/16/20, 10:45
-
TYPO3com voted on patch set 2 V +1 05/16/20, 10:45 Completed build in 11m 50s on Sat, 16 May, 10:45 AM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3401
-
Helmut Hummel updated the commit message in patch set 3 05/16/20, 10:47
-
Helmut Hummel voted on patch set 3 CR +1 05/16/20, 10:47
-
TYPO3com voted on patch set 3 V -1 05/16/20, 11:03 Completed build in 15m 31s on Sat, 16 May, 11:03 AM Test Summary: 72237 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3402
-
TYPO3com voted on patch set 3 V +1 05/16/20, 11:31 Completed build in 59m 34s on Sat, 16 May, 11:31 AM Test Summary: 73726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3402
-
Jonas Götze commented on patch set 3 V -1 05/16/20, 12:30
The previous Exception is gone, but test with autocomplete was still not working when trying to actually use it. The Ajax Request fails with: Oops, an error occurred! Code: 20200516121215e2bfef05 - {"exception":"ReflectionException: Class does not exist in /var/www/html/typo3/sysext/extbase/Classes/Reflection/ClassSchema.php:127 Stack trace: #0 /var/www/html/typo3/sysext/extbase/Classes/Reflection/ClassSchema.php(127): ReflectionClass->__construct('') #1 /var/www/html/typo3/sysext/extbase/Classes/Reflection/ReflectionService.php(118): TYPO3\\CMS\\Extbase\\Reflection\\ClassSchema->__construct('') #2 /var/www/html/typo3/sysext/extbase/Classes/Reflection/ReflectionService.php(105): TYPO3\\CMS\\Extbase\\Reflection\\ReflectionService->buildClassSchema('') #3 /var/www/html/typo3/sysext/extbase/Classes/Object/Container/Container.php(159): TYPO3\\CMS\\Extbase\\Reflection\\ReflectionService->getClassSchema('') #4 /var/www/html/typo3/sysext/extbase/Classes/Object/Container/Container.php(111): TYPO3\\CMS\\Extbase\\Object\\Container\\Container->getInstanceInternal('') #5 /var/www/html/typo3/sysext/extbase/Classes/Object/ObjectManager.php(118): TYPO3\\CMS\\Extbase\\Object\\Container\\Container->getInstance('', Array) #6 /var/www/html/typo3/sysext/extbase/Classes/Mvc/Dispatcher.php(111): TYPO3\\CMS\\Extbase\\Object\\ObjectManager->get('') #7 /var/www/html/typo3/sysext/extbase/Classes/Mvc/Dispatcher.php(87): TYPO3\\CMS\\Extbase\\Mvc\\Dispatcher->resolveController(Object(TYPO3\\CMS\\Fluid\\Core\\Widget\\WidgetRequest)) #8 /var/www/html/typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestHandler.php(89): TYPO3\\CMS\\Extbase\\Mvc\\Dispatcher->dispatch(Object(TYPO3\\CMS\\Fluid\\Core\\Widget\\WidgetRequest), Object(TYPO3\\CMS\\Extbase\\Mvc\\Web\\Response)) #9 /var/www/html/typo3/sysext/extbase/Classes/Core/Bootstrap.php(183): TYPO3\\CMS\\Fluid\\Core\\Widget\\WidgetRequestHandler->handleRequest() #10 /var/www/html/typo3/sysext/extbase/Classes/Core/Bootstrap.php(173): TYPO3\\CMS\\Extbase\\Core\\Bootstrap->handleRequest() #11 /var/www/html/typo3/sysext/fluid/Classes/Core/Widget/Bootstrap.php(64): TYPO3\\CMS\\Extbase\\Core\\Bootstrap->run('', Array) #12 [internal function]: TYPO3\\CMS\\Fluid\\Core\\Widget\\Bootstrap->run('', Array) #13 /var/www/html/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php(5615): call_user_func_array(Array, Array) #14 /var/www/html/typo3/sysext/frontend/Classes/ContentObject/UserContentObject.php(43): TYPO3\\CMS\\Frontend\\ContentObject\\ContentObjectRenderer->callUserFunction('TYPO3\\\\CMS\\\\Fluid...', Array, '') #15 /var/www/html/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php(822): TYPO3\\CMS\\Frontend\\ContentObject\\UserContentObject->render(Array) #16 /var/www/html/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php(736): TYPO3\\CMS\\Frontend\\ContentObject\\ContentObjectRenderer->render(Object(TYPO3\\CMS\\Frontend\\ContentObject\\UserContentObject), Array) #17 /var/www/html/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php(3085): TYPO3\\CMS\\Frontend\\ContentObject\\ContentObjectRenderer->cObjGetSingle('USER', Array) #18 /var/www/html/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php(3044): TYPO3\\CMS\\Frontend\\Controller\\TypoScriptFrontendController->processNonCacheableContentPartsAndSubstituteContentMarkers(Array) #19 /var/www/html/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php(3013): TYPO3\\CMS\\Frontend\\Controller\\TypoScriptFrontendController->recursivelyReplaceIntPlaceholdersInContent() #20 /var/www/html/typo3/sysext/frontend/Classes/Http/RequestHandler.php(150): TYPO3\\CMS\\Frontend\\Controller\\TypoScriptFrontendController->INTincScript() #21 /var/www/html/typo3/sysext/frontend/Classes/Middleware/OutputCompression.php(48): TYPO3\\CMS\\Frontend\\Http\\RequestHandler->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #22 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\OutputCompression->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(TYPO3\\CMS\\Frontend\\Http\\RequestHandler)) #23 /var/www/html/typo3/sysext/frontend/Classes/Middleware/ContentLengthResponseHeader.php(47): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #24 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\ContentLengthResponseHeader->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #25 /var/www/html/typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php(67): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #26 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\ShortcutAndMountPointRedirect->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #27 /var/www/html/typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php(86): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #28 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\PrepareTypoScriptFrontendRendering->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #29 /var/www/html/typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php(110): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #30 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\TypoScriptFrontendInitialization->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #31 /var/www/html/typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php(116): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #32 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Workspaces\\Middleware\\WorkspacePreview->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #33 /var/www/html/typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php(131): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #34 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\PageArgumentValidator->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #35 /var/www/html/typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php(65): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #36 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\PreviewSimulator->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #37 /var/www/html/typo3/sysext/frontend/Classes/Middleware/PageResolver.php(106): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #38 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\PageResolver->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #39 /var/www/html/typo3/sysext/redirects/Classes/Http/Middleware/RedirectHandler.php(81): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #40 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Redirects\\Http\\Middleware\\RedirectHandler->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #41 /var/www/html/typo3/sysext/frontend/Classes/Middleware/StaticRouteResolver.php(80): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #42 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\StaticRouteResolver->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #43 /var/www/html/typo3/sysext/frontend/Classes/Middleware/SiteBaseRedirectResolver.php(88): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #44 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\SiteBaseRedirectResolver->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #45 /var/www/html/typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php(77): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #46 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\FrontendUserAuthenticator->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #47 /var/www/html/typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php(66): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #48 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\BackendUserAuthenticator->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #49 /var/www/html/typo3/sysext/frontend/Classes/Middleware/SiteResolver.php(65): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #50 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\SiteResolver->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #51 /var/www/html/typo3/sysext/frontend/Classes/Middleware/MaintenanceMode.php(55): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #52 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\MaintenanceMode->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #53 /var/www/html/typo3/sysext/frontend/Classes/Middleware/EidHandler.php(64): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #54 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\EidHandler->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #55 /var/www/html/typo3/sysext/core/Classes/Middleware/NormalizedParamsAttribute.php(45): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #56 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Core\\Middleware\ ormalizedParamsAttribute->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #57 /var/www/html/typo3/sysext/frontend/Classes/Middleware/TimeTrackerInitialization.php(58): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #58 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(172): TYPO3\\CMS\\Frontend\\Middleware\\TimeTrackerInitialization->process(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest), Object(class@anonymous)) #59 /var/www/html/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php(78): class@anonymous->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #60 /var/www/html/typo3/sysext/core/Classes/Http/AbstractApplication.php(85): TYPO3\\CMS\\Core\\Http\\MiddlewareDispatcher->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #61 /var/www/html/typo3/sysext/frontend/Classes/Http/Application.php(64): TYPO3\\CMS\\Core\\Http\\AbstractApplication->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #62 /var/www/html/typo3/sysext/core/Classes/Http/AbstractApplication.php(97): TYPO3\\CMS\\Frontend\\Http\\Application->handle(Object(TYPO3\\CMS\\Core\\Http\\ServerRequest)) #63 /var/www/html/index.php(25): TYPO3\\CMS\\Core\\Http\\AbstractApplication->run() #64 /var/www/html/index.php(26): {closure}() #65 {main} -
Oliver Hader commented on patch set 3 05/16/20, 12:34
`ReflectionService` issues are handled in issue #91404 - please test patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/64494 on top of this very change. -
Oliver Hader uploaded patch set 4 05/16/20, 13:19
-
Oliver Hader commented on patch set 4 05/16/20, 13:23
→ please use this patch for TYPO3 v9.5: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64503 I'm now getting similar responses in TYPO3 v10 `UnknownClassException` in `ReflectionService::buildClassSchema('')` (called with empty string as argument). I was not able to narrow that down... could be dependency injection, caches, I just don't know... -
TYPO3com voted on patch set 4 V +1 05/16/20, 13:36 Completed build in 17m 49s on Sat, 16 May, 01:36 PM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3405
-
Alexander Schnitzler commented on patch set 4 V +1 05/16/20, 18:01
Having this patch applied to allow the usage of sessions and storing widget data and this patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/64505 to fix the missing controller object name, I have a fully working autocomplete widget. -
Alexander Schnitzler commented on patch set 4 05/16/20, 18:05
AjaxWidgetContextHolder.php:123Missing space after or. -
Jonas Götze commented on patch set 4 V +1 05/16/20, 19:59
I can also confirm it is working fine with 64501/4 and 64505/2 applied. -
Oliver Hader commented on patch set 5 05/17/20, 07:33
Published edit on patch set 4. -
Oliver Hader commented on patch set 5 05/17/20, 07:33
AjaxWidgetContextHolder.php:123ReplyAck -
TYPO3com voted on patch set 5 V +1 05/17/20, 07:45 Completed build in 12m 00s on Sun, 17 May, 07:45 AM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3410
-
Susi Moog updated the commit message in patch set 6 05/18/20, 05:15
-
TYPO3com voted on patch set 6 V +1 05/18/20, 05:29 Completed build in 13m 53s on Mon, 18 May, 05:28 AM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3416
-
Jonas Götze voted on patch set 6 V +1 05/18/20, 06:03
-
Alexander Schnitzler voted on patch set 6 V +1 CR +1 05/18/20, 09:05
-
Andreas Kienast voted on patch set 6 CR +1 05/18/20, 09:35
-
Andreas Kienast voted on patch set 6 V +2 CR +2 05/18/20, 09:35
-
Susi Moog voted on patch set 6 V +1 CR +1 05/18/20, 09:35
-
Andreas Kienast merged patch set 7 05/18/20, 09:35