Review 9.5 Merged

64503[BUGFIX] Allow arbitrary objects in widget context

Oliver Hader CR +2 V +2 Normal +42 −82 updated 05/18/20, 09:35

Commit message

TYPO3-CORE-SA-2020-005 cause side-effects on Fluid AJAX widgets which
unfortunatelly support any class instance to be temporarily stored in
the current user-session. With mentioned change to address an insecure
deserialization vulnerability it was limited to items that could be
JSON-serialized.

This limitation is removed again by switching back to `unserialize()`,
but using an encryption-key-based HMAC signature on the payload.
Due to its architecture there is no better approach available.

This partially reverts commit 7d4159f79190652d567e6e40f856ffcdf5cf6b02.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 69

  1. Oliver Hader uploaded patch set 1 05/16/20, 13:18

  2. TYPO3com voted on patch set 1 V +1 05/16/20, 13:32 Completed build in 13m 40s on Sat, 16 May, 01:32 PM Test Summary: 74893 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-620

  3. Oliver Hader commented on patch set 2 05/17/20, 07:33

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 05/17/20, 07:50 Completed build in 16m 49s on Sun, 17 May, 07:50 AM Test Summary: 74893 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-621

  5. Oliver Hader updated the commit message in patch set 3 05/18/20, 06:54

  6. TYPO3com voted on patch set 3 V +1 05/18/20, 07:14 Completed build in 17m 02s on Mon, 18 May, 07:14 AM Test Summary: 74893 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-622

  7. Alexander Schnitzler voted on patch set 3 V +1 CR +1 05/18/20, 09:05

  8. Andreas Kienast voted on patch set 3 V +2 CR +2 05/18/20, 09:35

  9. Andreas Kienast merged patch set 4 05/18/20, 09:35