Review main Abandoned

64504[BUGFIX] Check dependency prior to widget registration

Oli Bartsch CR 0 V 0 Easy +23 −14 updated 07/15/20, 08:40

Commit message

The `t3information` widget has a dependency to ext:about
since it uses the `cms_description` label for its output.

To prevent the widget from being displayed without any content,
the widget is now only registered if ext:about is loaded.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 78

  1. Oli Bartsch uploaded patch set 1 05/16/20, 16:22

  2. TYPO3com voted on patch set 1 V +1 05/16/20, 16:34 Completed build in 11m 29s on Sat, 16 May, 04:34 PM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3406

  3. Richard Haeser commented on patch set 1 05/21/20, 06:30

    Although the approach is fine, I think that we should fix the real issue. This widget should not depend (with language labels) on EXT:about. So you found a good point, but the way we should handle it, should be differently if you ask me.
  4. Oli Bartsch commented on patch set 1 05/21/20, 09:26

    > Patch Set 1: > > Although the approach is fine, I think that we should fix the real issue. This widget should not depend (with language labels) on EXT:about. So you found a good point, but the way we should handle it, should be differently if you ask me. I also thought about this because this dependency is like you said, really low. But I was not sure if duplicating the label in the dashbaord extension can be the solution. Anyways, if this is the preferred way, I will update the patchset.
  5. Susi Moog commented on patch set 1 05/22/20, 20:05

    If the only dependency is the label, then we should duplicate that in this case (also because it is in fact used in a slightly different context with the widget).
  6. Benni Mack updated the commit message in patch set 2 05/25/20, 18:53

  7. Richard Haeser commented on patch set 2 07/14/20, 21:46

    Solved the underlying issue in https://review.typo3.org/c/Packages/TYPO3.CMS/+/65038. I think this patch can be abandoned.
  8. Oli Bartsch abandoned the change 07/15/20, 08:40