Review main Merged

64505[BUGFIX] Set controller object name for widget request

Alexander Schnitzler CR +2 V +2 Easy +14 −13 updated 05/18/20, 10:27

Commit message

While introducing the fully qualified controller class names
in the extbase plugin configuration the originally used setter
\TYPO3\CMS\Extbase\Mvc\Request::setControllerObjectName() has
no longer been used to guess extension name, subpackage key and
controller name from the class name since all that information
is known. Said setter has been kept nevertheless and it was
overlooked that it was still used by fluid widgets. This leads
to property \TYPO3\CMS\Extbase\Mvc\Request::$controllerObjectName
being empty in widget requests which then leads to an exception
when trying to create a ClassSchema for the controller object
name "".

To fix this, the widget request is now created with the controller
object name as constructor argument.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Susi Moog +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1420

  1. Alexander Schnitzler uploaded patch set 1 05/16/20, 17:45

  2. Alexander Schnitzler uploaded patch set 2 05/16/20, 17:53

  3. TYPO3com voted on patch set 1 V -1 05/16/20, 17:58 Completed build in 12m 48s on Sat, 16 May, 05:58 PM Test Summary: 6 of 74211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3407

  4. TYPO3com voted on patch set 2 V +1 05/16/20, 18:05 Completed build in 12m 29s on Sat, 16 May, 06:05 PM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3408

  5. Alexander Schnitzler commented on patch set 2 05/16/20, 18:06

    This change is ready for review.
  6. Oliver Hader voted on patch set 2 CR +1 05/17/20, 07:31

  7. Oliver Hader voted on patch set 2 V +1 05/17/20, 07:36

  8. Oliver Hader commented on patch set 2 05/17/20, 18:28

    Is thi
    Is it required in TYPO3 v9? `Request::getControllerObjectName()` is trying to assemble the name from vendor, extension, controller - it's also possible that I'm overlooking something here
  9. Alexander Schnitzler commented on patch set 2 CR -1 05/18/20, 07:49

    Reply

    I will double check soon. I was quite sure I adjusted the resolving of the controller class name in 9.5 already. Will put a -1 for now.
  10. Alexander Schnitzler updated the commit message in patch set 3 05/18/20, 09:06

  11. Alexander Schnitzler commented on patch set 3 05/18/20, 09:06

    Reply

    Not needed for 9.5
  12. TYPO3com voted on patch set 3 V -1 05/18/20, 09:19 Completed build in 13m 08s on Mon, 18 May, 09:19 AM Test Summary: 73466 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3424

  13. TYPO3com voted on patch set 3 V +1 05/18/20, 09:26 Completed build in 33m 15s on Mon, 18 May, 09:26 AM Test Summary: 73781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3424

  14. Alexander Schnitzler updated the commit message in patch set 4 05/18/20, 09:46

  15. Susi Moog voted on patch set 4 V +1 CR +1 05/18/20, 09:48

  16. TYPO3com voted on patch set 4 V -1 05/18/20, 10:06 Completed build in 15m 08s on Mon, 18 May, 10:06 AM Test Summary: 1 of 74265 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3429

  17. TYPO3com voted on patch set 4 V +1 05/18/20, 10:25 Completed build in 49m 22s on Mon, 18 May, 10:25 AM Test Summary: 73781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3429

  18. Oliver Hader voted on patch set 4 V +2 CR +2 05/18/20, 10:26

  19. Oliver Hader commented on patch set 4 05/18/20, 10:27

    Reply

    Ack
  20. Oliver Hader merged patch set 5 05/18/20, 10:27