Review main Merged

64507[BUGFIX] Respect selected language id in columns mode

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 09/18/20, 18:49

Commit message

To not falsely show content as "unused" if not translated yet,
content fetcher must respect the language, selected for columns
mode, in the fluid based page module.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Riccardo De Contardi +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Oli Bartsch uploaded patch set 1 05/17/20, 11:25

  2. TYPO3com voted on patch set 1 V +1 05/17/20, 11:36 Completed build in 11m 19s on Sun, 17 May, 11:36 AM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3411

  3. Riccardo De Contardi commented on patch set 1 V +1 05/17/20, 14:03

    works on latest master, with the test described on https://forge.typo3.org/issues/91350
  4. Benni Mack updated the commit message in patch set 2 05/25/20, 18:52

  5. Riccardo De Contardi commented on patch set 2 V +1 08/02/20, 16:24

    Only commit message changes, so I think I can revote this (works on Master)
  6. TYPO3com voted on patch set 2 V +1 08/03/20, 06:51 Completed build in 12m 19s on Mon, 3 Aug, 06:51 AM Test Summary: 73000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4368

  7. Jörg Bösche voted on patch set 2 CR +1 09/02/20, 07:20

  8. Daniel Goerz voted on patch set 2 V +1 CR +1 09/18/20, 07:45

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 09/18/20, 18:43

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/18/20, 18:49

  11. Anja Leichsenring merged patch set 3 09/18/20, 18:49