Review main Merged

64508[BUGFIX] Prevent null pointer exception in LocalizationUtility

Oli Bartsch CR +2 V +2 Easy +3 −1 updated 05/21/20, 16:07

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Oli Bartsch uploaded patch set 1 05/17/20, 11:49

  2. TYPO3com voted on patch set 1 V +1 05/17/20, 11:59 Completed build in 10m 49s on Sun, 17 May, 11:59 AM Test Summary: 73727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3412

  3. Oliver Klee commented on patch set 1 05/17/20, 12:08

    LocalizationUtility.php:200

    This won't avoid the warning in line 204 then. Can we have a default value for the language key?
  4. Oli Bartsch commented on patch set 1 05/17/20, 12:13

    LocalizationUtility.php:200 Reply

    This key is already set with a default value in line 192.
  5. Oliver Klee commented on patch set 1 05/17/20, 14:34

    LocalizationUtility.php:200 Reply Unresolved

    Indeed. Thanks!
  6. Georg Ringer voted on patch set 1 V +1 CR +1 05/20/20, 08:45

  7. Oliver Klee voted on patch set 1 CR +1 05/20/20, 10:09

  8. Josef Glatz voted on patch set 1 V +1 CR +1 05/21/20, 06:22

  9. Daniel Goerz voted on patch set 1 V +2 CR +2 05/21/20, 16:07

  10. Daniel Goerz merged patch set 2 05/21/20, 16:07