Review main Merged

64511[BUGFIX] Correctly double and single quotes in page tree tooltips

Christian Eßl CR +2 V +2 Easy +4 −1 updated 11/15/21, 09:05

Commit message

There were several problems with tooltips in the page tree:

- htmlspecialchars was applied twice to the tooltip string. Once in
BackendUtility::titleAttribForPages, once in TreeController.
- When applying double or single quotes to a page title, the tooltips in
the page tree would show these as html entities.

Double and single quotes are now allowed, while any potential html tags
in the title will be stripped from the tooltip. Any of those characters
(", ', <, >) left in the tooltip are later escaped to unicode in the
json view.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Christian Eßl uploaded patch set 1 05/18/20, 07:51

  2. TYPO3com voted on patch set 1 V +1 05/18/20, 08:04 Completed build in 12m 21s on Mon, 18 May, 08:04 AM Test Summary: 73725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3420

  3. Oliver Hader commented on patch set 1 CR -1 05/18/20, 08:59

    Has to be checked carefully on how and where `tip` is uses... otherwise there's the chance to introduce new cross-site scripting
  4. Benni Mack updated the commit message in patch set 2 05/25/20, 18:52

  5. Benni Mack updated the commit message in patch set 3 10/20/21, 15:57

  6. Benni Mack rebased onto patch set 4 10/20/21, 15:57

  7. core-ci voted on patch set 4 V +1 10/20/21, 16:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18390

  8. Oliver Hader commented on patch set 4 CR -1 10/20/21, 16:46

    For reasons I'd like to verify that...
  9. Oliver Hader uploaded patch set 5 11/15/21, 08:32

  10. Oliver Hader voted on patch set 5 V +1 CR +1 11/15/21, 08:32

  11. Benni Mack voted on patch set 5 V +1 CR +1 11/15/21, 08:46

  12. core-ci voted on patch set 5 V +1 11/15/21, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19276

  13. Oliver Hader voted on patch set 5 V +2 CR +2 11/15/21, 09:05

  14. Oliver Hader merged patch set 6 11/15/21, 09:05