Review main Merged

64512[BUGFIX] Use checksum of frontend groups in cache identifier

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 05/18/20, 20:17

Commit message

The generated cache identifier may get very long in case a page has many
frontend groups configured and may exceeds the limit of the caching
frontend (which is 250 characthers per definition in
FrontendInterface::PATTERN_ENTRYIDENTIFIER). To bypass this issue, the
group list is hashed now.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Frank W Blank +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 610

  1. Andreas Kienast uploaded patch set 1 05/18/20, 09:29

  2. TYPO3com voted on patch set 1 V -1 05/18/20, 09:41 Completed build in 12m 26s on Mon, 18 May, 09:41 AM Test Summary: 5 of 74265 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3426

  3. TYPO3com voted on patch set 1 V +1 05/18/20, 09:49 Completed build in 32m 17s on Mon, 18 May, 09:49 AM Test Summary: 73781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3426

  4. Benjamin Franzke updated the commit message in patch set 2 2 comments 05/18/20, 09:51

  5. TYPO3com voted on patch set 2 V -1 05/18/20, 10:11 Completed build in 20m 19s on Mon, 18 May, 10:11 AM Test Summary: 1 of 74265 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3430

  6. TYPO3com voted on patch set 2 V +1 05/18/20, 10:17 Completed build in 46m 45s on Mon, 18 May, 10:17 AM Test Summary: 73781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3430

  7. Oliver Hader voted on patch set 2 CR +1 05/18/20, 12:36

  8. Frank W Blank commented on patch set 2 V +1 05/18/20, 20:08

    > Patch Set 2: Verified+1 > > Completed build in 46m 45s on Mon, 18 May, 10:17 AM > Test Summary: 73781 passed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3430 tested it on ddev 1.14.2, stage and live
  9. Benjamin Franzke commented on patch set 2 V +2 CR +2 05/18/20, 20:17

    In this case the 'runtime' cache is used and no database cache is involved at all. The issue seems to be that VariableFrontend (as used for 'runtime' cache) allows up to 250chars as specified by FrontendInterface::PATTERN_ENTRYIDENTIFIER.

    PageRepository.php:1401

    Just a small hint: I initially tought: "Let's leave $field and $table human readable in here", otherwise: It's just a runtimecache, so no need to debug cache entries that have been stored.
  10. Benjamin Franzke merged patch set 3 05/18/20, 20:17