Review main Abandoned

64515[BUGFIX] Prevent returning empty (0) ancestor ID

Xavier Perseguers CR 0 V 0 Easy +6 −3 updated 05/05/21, 09:22

Commit message

When resolving localization ancestors for a given record, various
"parent" fields are considered. It is important to never return an
empty (0) parent field as it will wrongly take totally unrelated
records as being dependent.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 2330

Show 45 earlier messages
  1. Xavier Perseguers uploaded patch set 1 05/18/20, 12:43

  2. TYPO3com voted on patch set 1 V -1 05/18/20, 12:56 Completed build in 12m 47s on Mon, 18 May, 12:56 PM Test Summary: 30 of 74199 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3435

  3. Xavier Perseguers commented on patch set 1 05/18/20, 13:24

    @olly: Since you worked a lot in the translation field, I'd like you to have a look at all the details in my bug report. Many thanks.
  4. Daniel Goerz commented on patch set 1 CR -1 05/22/20, 19:42

    DataMapProcessor.php:1216

    This looks wrong. Did you mean to write isset($element[$fieldNames['parent']])?
  5. Xavier Perseguers commented on patch set 1 05/25/20, 06:36

    DataMapProcessor.php:1216 Reply Unresolved

    indeed, that was the idea, and possibly explains the other strange bug I had with this patch in another context. Thx for your sharp eyes.
  1. Xavier Perseguers uploaded patch set 2 05/25/20, 06:37

  2. TYPO3com voted on patch set 2 V +1 05/25/20, 06:50 Completed build in 12m 49s on Mon, 25 May, 06:50 AM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3510

  3. Benni Mack updated the commit message in patch set 3 05/25/20, 18:53

  4. TYPO3com voted on patch set 3 V +1 05/25/20, 20:24 Completed build in 29m 14s on Mon, 25 May, 08:24 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3545

  5. Benni Mack voted on patch set 3 CR +1 06/04/20, 19:22

  6. Markus Klein commented on patch set 3 10/06/20, 10:36

    DataMapProcessor.php:1212

    same check necessary here too?
  7. Xavier Perseguers commented on patch set 3 10/06/20, 11:33

    DataMapProcessor.php:1212 Reply

    I don't think so, the bug occurs because hereafter we casted null to 0, which is not the case at the point anyway.
  8. Markus Klein commented on patch set 3 10/06/20, 20:34

    DataMapProcessor.php:1212 Reply Unresolved

    still the source field might not exist in $element and hence we got a PHP notice problem here too. Will update
  9. Markus Klein commented on patch set 4 10/06/20, 20:35

    Published edit on patch set 3.
  10. Markus Klein voted on patch set 4 CR +1 10/06/20, 20:36

  11. TYPO3com voted on patch set 4 V +1 10/06/20, 20:50 Completed build in 14m 46s on Tue, 6 Oct, 08:50 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6303

  12. Benni Mack voted on patch set 4 CR +1 11/10/20, 11:39

  13. Markus Klein commented on patch set 4 CR -1 11/10/20, 14:48

    @Xavier: I posted two questions in the ticket. Please lets figure this out first.
  14. Xavier Perseguers uploaded patch set 5 11/12/20, 09:38

  15. TYPO3com voted on patch set 5 V +1 11/12/20, 09:50 Completed build in 12m 23s on Thu, 12 Nov, 09:50 AM Test Summary: 73644 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7263

  16. Markus Klein voted on patch set 5 CR +1 11/12/20, 13:43

  17. Alexander Opitz commented on patch set 5 05/04/21, 23:05

    I'd the same issue and wrote nearly same solution in https://review.typo3.org/c/Packages/TYPO3.CMS/+/69013

    DataMapProcessor.php:1236 Unresolved

    This returns the fieldName for source as integer but it should return the value of this field
  18. Alexander Opitz voted on patch set 5 CR -1 05/04/21, 23:06

  19. Alexander Opitz commented on patch set 5 05/05/21, 06:58

    DataMapProcessor.php:1234 Unresolved

    For me it seams this line is not needed. * If source is not parent we use source * If source is same as parent we use parent which is the same as source So we could use source if it is set and not empty.
  20. Alexander Opitz uploaded patch set 6 05/05/21, 07:14

  21. core-ci voted on patch set 6 V +1 05/05/21, 07:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11185

  22. Alexander Opitz uploaded patch set 7 05/05/21, 07:29

  23. Markus Klein commented on patch set 7 05/05/21, 07:39

    DataMapProcessor.php:1223 Unresolved

    This comment is now wrong?
  24. core-ci voted on patch set 7 V +1 05/05/21, 07:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11186

  25. Oliver Hader abandoned the change 05/05/21, 09:22

    → please lets continue with https://review.typo3.org/c/Packages/TYPO3.CMS/+/58049 (which was there long time already)