Review main Merged

64520[BUGFIX] Loosen site check for records not stored in site context

Helmut Hummel CR +2 V +2 Easy +8 −1 updated 05/19/20, 12:51

Commit message

When saving a record on a page that is not part of a site,
the slug field of this record, despite being set to "uniqueInSite"
is not checked for uniqueness, as it is assumed unique enough.

This assumption needs to be applied as well when resolving
the record, instead of assuming the resolved record is not part
of the current site.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1014

  1. Helmut Hummel uploaded patch set 1 05/19/20, 10:14

  2. TYPO3com voted on patch set 1 V -1 05/19/20, 10:26 Completed build in 11m 28s on Tue, 19 May, 10:26 AM Test Summary: 1 of 74283 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3442

  3. Helmut Hummel updated the commit message in patch set 2 05/19/20, 10:49

  4. TYPO3com voted on patch set 2 V -1 05/19/20, 11:10 Completed build in 20m 59s on Tue, 19 May, 11:10 AM Test Summary: 1 of 72995 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3444

  5. Oliver Klee commented on patch set 2 05/19/20, 11:38

    "Loose" is not a verb. This should be either "Lose" or "Loosen".
  6. Benni Mack updated the commit message in patch set 3 05/19/20, 11:59

  7. Benni Mack updated the commit message in patch set 4 05/19/20, 11:59

  8. Oliver Hader voted on patch set 4 CR +1 05/19/20, 12:08

  9. Benni Mack voted on patch set 4 CR +1 05/19/20, 12:11

  10. TYPO3com voted on patch set 3 V -1 05/19/20, 12:12 Completed build in 12m 42s on Tue, 19 May, 12:12 PM Test Summary: 1 of 74283 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3447

  11. TYPO3com voted on patch set 4 V +1 05/19/20, 12:17 Completed build in 17m 47s on Tue, 19 May, 12:17 PM Test Summary: 73799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3448

  12. Helmut Hummel commented on patch set 4 05/19/20, 12:51

    Reply

    Thanks!
  13. Oliver Hader voted on patch set 4 V +2 CR +2 05/19/20, 12:51

  14. Oliver Hader merged patch set 5 05/19/20, 12:51