Review main Merged

64522[TASK] Replace pagination widget in ext be_user

Alexander Schnitzler CR +2 V +2 Normal +140 −16 updated 08/31/20, 12:20

Commit message

Instead of using the be.widget.paginate widget, backend users
and groups are now paginated with a QueryResultPaginator and
the pagination is build with the help of a SimplePagination
instance.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1423

  1. Alexander Schnitzler uploaded patch set 1 05/19/20, 11:32

  2. TYPO3com voted on patch set 1 V +1 05/19/20, 11:44 Completed build in 11m 58s on Tue, 19 May, 11:44 AM Test Summary: 73799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3446

  3. Alexander Schnitzler uploaded patch set 2 08/13/20, 15:24

  4. Alexander Schnitzler uploaded patch set 3 08/13/20, 15:28

  5. TYPO3com voted on patch set 2 V +1 08/13/20, 15:36 Completed build in 11m 54s on Thu, 13 Aug, 03:36 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4642

  6. TYPO3com voted on patch set 3 V -1 08/13/20, 15:45 Completed build in 14m 25s on Thu, 13 Aug, 03:45 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4644

  7. TYPO3com commented on patch set 3 08/14/20, 07:36 Completed build in 16h 20m 30s on Fri, 14 Aug, 07:36 AM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4644

  8. Alexander Schnitzler uploaded patch set 4 08/14/20, 07:39

  9. TYPO3com voted on patch set 4 V +1 08/14/20, 07:50 Completed build in 11m 00s on Fri, 14 Aug, 07:50 AM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4651

  10. Daniel Windloff commented on patch set 4 V +1 CR +1 08/15/20, 16:28

    Test pagination (with and without filter) of users; test pagination of user groups.
  11. Daniel Goerz commented on patch set 4 CR -1 08/19/20, 18:23

    PaginatedList.html:20 Unresolved

    Whats with the "s" at the end of the line?

    PaginatedList.html:27 Unresolved

    the whole pagination thingy looks like duplicated code, can we move that to a partial?

    PaginatedList.html:68 Unresolved

    why the view helper?
  12. Alexander Schnitzler uploaded patch set 5 08/24/20, 14:40

  13. TYPO3com voted on patch set 5 V -1 08/24/20, 14:54 Completed build in 14m 42s on Mon, 24 Aug, 02:54 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4901

  14. Alexander Schnitzler uploaded patch set 6 08/24/20, 15:01

  15. TYPO3com voted on patch set 6 V -1 08/24/20, 15:38 Completed build in 36m 28s on Mon, 24 Aug, 03:38 PM Test Summary: 9 of 73546 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4905

  16. TYPO3com voted on patch set 6 V +1 08/24/20, 16:16 Completed build in 1h 50m 58s on Mon, 24 Aug, 04:16 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4905

  17. Jörg Bösche uploaded patch set 7 08/25/20, 10:02

  18. Jörg Bösche commented on patch set 7 08/25/20, 10:06

    Patchset 7: Moved fluid additional attributes to native attributes in SimplePagination.html, because there is no fluid viewhelper used. Also the page number was missing in the input field, because of missing variable (paginator) assignment to partial. Added the paginator variable to BackendUserGroup file, because of usages in SimplePagination.html file.
  19. TYPO3com voted on patch set 7 V +1 08/25/20, 10:14 Completed build in 11m 40s on Tue, 25 Aug, 10:14 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4938

  20. Alexander Schnitzler commented on patch set 7 08/25/20, 16:06

    > Patch Set 7: > > Patchset 7: > > Moved fluid additional attributes to native attributes in SimplePagination.html, because there is no fluid viewhelper used. Also the page number was missing in the input field, because of missing variable (paginator) assignment to partial. > > Added the paginator variable to BackendUserGroup file, because of usages in SimplePagination.html file. thanks, totally missed all that.
  21. Jörg Bösche voted on patch set 7 V +1 CR +1 08/26/20, 12:35

  22. Benni Mack voted on patch set 7 V +2 CR +2 08/31/20, 12:20

  23. Benni Mack merged patch set 8 08/31/20, 12:20