Review main Merged

64524[TASK] Replace pagination widget in ext extensionmanager

Alexander Schnitzler CR +2 V +2 Normal +128 −13 updated 09/04/20, 12:03

Commit message

Instead of using the be.widget.paginate widget, extensions are
now paginated with a QueryResultPaginator and the pagination is
build with the help of a SimplePagination instance.

Since there is an ArrayPaginator in the core as well, the search
result list is now paginated as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1015

  1. Alexander Schnitzler uploaded patch set 1 05/19/20, 12:48

  2. TYPO3com voted on patch set 1 V -1 05/19/20, 13:02 Completed build in 13m 48s on Tue, 19 May, 01:02 PM Test Summary: 3 of 63881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3449

  3. Alexander Schnitzler uploaded patch set 2 05/19/20, 13:50

  4. TYPO3com voted on patch set 2 V -1 05/19/20, 14:28 Completed build in 17m 38s on Tue, 19 May, 02:28 PM Test Summary: 4 of 74285 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3455

  5. TYPO3com voted on patch set 2 V +1 05/20/20, 16:15 Completed build in 2h 21m 50s on Wed, 20 May, 04:15 PM Test Summary: 73799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3455

  6. Oliver Hader commented on patch set 2 07/15/20, 15:20

    → https://review.typo3.org/c/Packages/TYPO3.CMS/+/65039 is removing the inline JavaScript
  7. Alexander Schnitzler uploaded patch set 3 08/14/20, 08:15

  8. TYPO3com voted on patch set 3 V +1 08/14/20, 08:26 Completed build in 10m 49s on Fri, 14 Aug, 08:26 AM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4652

  9. Jörg Bösche voted on patch set 3 V +1 CR +1 08/26/20, 14:11

  10. Alexander Schnitzler commented on patch set 3 09/03/20, 16:15

    ping
  11. Daniel Goerz uploaded patch set 4 09/04/20, 08:56

  12. Daniel Goerz voted on patch set 4 V +1 CR +1 09/04/20, 08:56

  13. TYPO3com voted on patch set 4 V +1 09/04/20, 09:09 Completed build in 12m 46s on Fri, 4 Sep, 09:09 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5218

  14. Benni Mack voted on patch set 4 V +2 CR +2 09/04/20, 12:03

  15. Benni Mack merged patch set 5 09/04/20, 12:03