Review 9.5 Merged

64525[BUGFIX] Loosen site check for records not stored in site context

Oliver Hader CR +2 V +2 Easy +9 −1 updated 05/19/20, 13:06

Commit message

When saving a record on a page that is not part of a site,
the slug field of this record, despite being set to "uniqueInSite"
is not checked for uniqueness, as it is assumed unique enough.

This assumption needs to be applied as well when resolving
the record, instead of assuming the resolved record is not part
of the current site.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Oliver Hader uploaded patch set 1 05/19/20, 12:49

  2. Oliver Hader voted on patch set 1 V +2 CR +1 05/19/20, 13:04

  3. Oliver Hader voted on patch set 1 CR +2 05/19/20, 13:05

  4. TYPO3com voted on patch set 1 V +1 05/19/20, 13:05 Completed build in 15m 31s on Tue, 19 May, 01:05 PM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-637

  5. Oliver Hader merged patch set 2 05/19/20, 13:06