64531[BUGFIX] Use URI of current request for referrer check
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Daniel Goerz +1
-
Verified V +2 Done
- Oliver Hader +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2532
Show 67 earlier messages
-
Andreas Kienast uploaded patch set 1 05/19/20, 14:23
-
Andreas Kienast updated the commit message in patch set 2 05/19/20, 14:31
-
Ingo Fabbri voted on patch set 2 V +1 CR +1 05/19/20, 14:35
-
Andreas Kienast commented on patch set 2 V -1 05/19/20, 14:36
According to Bamboo it seems the backend login itself is not happy now -
Ingo Fabbri commented on patch set 2 05/19/20, 14:38
> Patch Set 2: Verified-1 > > According to Bamboo it seems the backend login itself is not happy now backend login still works for me -
Ingo Fabbri commented on patch set 2 05/19/20, 14:38
> Patch Set 2: Verified-1 > > According to Bamboo it seems the backend login itself is not happy now backend login still works for me -
TYPO3com voted on patch set 1 V -1 05/19/20, 14:39 Completed build in 15m 58s on Tue, 19 May, 02:39 PM Test Summary: 72 of 74283 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3457
-
TYPO3com voted on patch set 2 V -1 05/19/20, 14:43 Completed build in 12m 17s on Tue, 19 May, 02:43 PM Test Summary: 72 of 74283 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3458
-
Andreas Kienast uploaded patch set 3 05/19/20, 15:14
-
Andreas Kienast uploaded patch set 4 05/19/20, 15:17
-
TYPO3com voted on patch set 3 V -1 05/19/20, 15:25 Completed build in 11m 15s on Tue, 19 May, 03:25 PM Test Summary: 72 of 74283 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3459
-
TYPO3com voted on patch set 4 V +1 05/19/20, 15:31 Completed build in 13m 16s on Tue, 19 May, 03:31 PM Test Summary: 73798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3460
-
Markus Klein commented on patch set 4 05/19/20, 17:24
How to test this best? pwd reset feature? -
Andreas Kienast commented on patch set 4 05/19/20, 18:17
> Patch Set 4: > > How to test this best? pwd reset feature? Yes. Without the patch you‘re not able to set a new pasword once you opened the link in the mail as you get redirected to the backend login again. -
Alexander Opitz commented on patch set 4 05/19/20, 18:20
This also happens with older versions so not master only -
Andreas Kienast commented on patch set 4 05/19/20, 18:26
> Patch Set 4: > > This also happens with older versions so not master only What do you mean? master is still 10.4 -
Alexander Opitz commented on patch set 4 05/19/20, 18:29
> Patch Set 4: > What do you mean? master is still 10.4 Yes, excuse my interruption the Release line doesn't mean the real releases in TYPO3 (it meant the branches). -
Andreas Kienast updated the commit message in patch set 5 05/19/20, 18:32
-
TYPO3com voted on patch set 5 V +1 05/19/20, 18:43 Completed build in 11m 22s on Tue, 19 May, 06:43 PM Test Summary: 73799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3465
-
Ingo Fabbri voted on patch set 5 CR +1 05/19/20, 18:53
-
Alexander Opitz voted on patch set 5 V +1 05/19/20, 19:03
-
Andreas Kießling commented on patch set 5 V +1 05/20/20, 06:43
Can this be backported to 8.7 ELTS too? The current implementation screws up our custom password reset extension. -
Ingo Fabbri commented on patch set 5 05/20/20, 07:00
LoginController.php:352Is this Change still necessary with the adjusted localstorage referer solution? -
Andreas Kienast commented on patch set 5 05/20/20, 07:01
LoginController.php:352Reply UnresolvedYes, because we have to click a link to get a referrer. -
Andreas Kienast commented on patch set 5 05/20/20, 07:02
> Patch Set 5: Verified+1 > > Can this be backported to 8.7 ELTS too? The current implementation screws up our custom password reset extension. This change will be backported to ELTS, too. -
Daniel Goerz voted on patch set 5 CR +1 05/22/20, 19:54
-
Benni Mack updated the commit message in patch set 6 05/25/20, 18:53
-
TYPO3com voted on patch set 6 V -1 05/26/20, 10:03 Completed build in 14m 41s on Tue, 26 May, 10:03 AM Test Summary: 2 of 74296 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3556
-
TYPO3com voted on patch set 6 V +1 05/26/20, 17:18 Completed build in 7h 43m 49s on Tue, 26 May, 05:18 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3556
-
Daniel Goerz voted on patch set 6 V +1 CR +1 06/21/20, 12:57
-
Oliver Hader voted on patch set 6 V +2 CR +2 07/07/20, 08:02
-
Oliver Hader wrote 07/07/20, 08:03
Change has been successfully rebased and submitted as 07331b4b59af03fd0a4031cc10fa421202d46661 by Oliver Hader