Review 9.5 Merged

64533[BUGFIX] Fixed order-by while querying old realurl table for slugs

Benni Mack CR +2 V +2 Easy +4 −3 updated 05/19/20, 12:01

Commit message

The old tx_realurl_pathcache does not have a uid field, but uses the
field cache_id. The order-by now uses a different field depending on
the table.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Benni Mack commented on patch set 1 05/19/20, 09:46

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 05/19/20, 10:00 Completed build in 13m 18s on Tue, 19 May, 10:00 AM Test Summary: 74586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-633

  3. TYPO3com voted on patch set 1 V +1 05/19/20, 10:56 Completed build in 1h 22m 40s on Tue, 19 May, 10:56 AM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-633

  4. Benni Mack voted on patch set 1 V +2 CR +2 05/19/20, 11:39

  5. Benni Mack merged patch set 2 05/19/20, 11:39

  6. Oliver Hader voted on patch set 2 CR +1 05/19/20, 12:01