Review 9.5 Merged

64534[TASK] Consistent version restrictions for PSR packages

Mathias Brodala CR +2 V +2 Easy +8 −8 updated 05/20/20, 09:52

Commit message

composer require "psr/http-message":"^1.0"
    composer require "psr/log":"^1.0"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 810

  1. Mathias Brodala commented on patch set 1 05/20/20, 08:38

    Cherry Picked from branch master. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/adminpanel/composer.json * typo3/sysext/core/composer.json * typo3/sysext/redirects/composer.json
  2. TYPO3com voted on patch set 1 V -1 05/20/20, 08:38 Completed build in 14s on Wed, 20 May, 08:38 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-640

  3. Mathias Brodala uploaded patch set 2 05/20/20, 08:47

  4. Mathias Brodala commented on patch set 2 05/20/20, 08:47

    This change is ready for review.
  5. Georg Ringer voted on patch set 2 CR +1 05/20/20, 08:50

  6. Simon Gilli voted on patch set 2 CR +1 05/20/20, 09:00

  7. TYPO3com voted on patch set 2 V +1 05/20/20, 09:05 Completed build in 17m 39s on Wed, 20 May, 09:05 AM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-642

  8. Benjamin Franzke commented on patch set 2 V +1 CR +1 05/20/20, 09:31

    Verified that psr/log 1.1 can (and will) now be installed using a composer.json that uses the git checkout of this patch: { "name": "bnf/typo39-composer-cms", "repositories": [ { "type": "path", "url": "../TYPO39.CMS/typo3/sysext/*", "options": { "symlink": true } }, { "type": "composer", "url": "https://composer.typo3.org/"; } ], "require": { "typo3/cms-backend": "dev-master as v9.5.0", "typo3/cms-core": "dev-master as v9.5.0", "typo3/cms-extbase": "dev-master as v9.5.0", "typo3/cms-extensionmanager": "dev-master as v9.5.0", "typo3/cms-filelist": "dev-master as v9.5.0", "typo3/cms-fluid": "dev-master as v9.5.0", "typo3/cms-frontend": "dev-master as v9.5.0", "typo3/cms-install": "dev-master as v9.5.0", "typo3/cms-recordlist": "dev-master as v9.5.0", "typo3/cms-composer-installers": "dev-master as v9.5.0" } }
  9. Benni Mack commented on patch set 2 V +2 CR +2 05/20/20, 09:51

    very nice one. Thank you!
  10. Benni Mack merged patch set 3 05/20/20, 09:52