Review main Merged

64553[BUGFIX] Correctly evaluate PageTS in TemplateModule

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 05/20/20, 08:41

Commit message

Set the current page id early, so that PageTS is fetched
from the correct page instead of id 0.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Thomas Hohn +1
    • Daniel Siepmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Helmut Hummel uploaded patch set 1 05/19/20, 21:13

  2. TYPO3com voted on patch set 1 V -1 05/19/20, 21:28 Completed build in 14m 36s on Tue, 19 May, 09:28 PM Test Summary: 1 of 71365 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3466

  3. Daniel Siepmann voted on patch set 1 CR +1 05/20/20, 05:53

  4. TYPO3com voted on patch set 1 V +1 05/20/20, 06:07 Completed build in 12m 26s on Wed, 20 May, 06:07 AM Test Summary: 73799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3469

  5. TYPO3com commented on patch set 1 05/20/20, 06:09 Completed build in 9h 10m 38s on Wed, 20 May, 06:09 AM Test Summary: 73799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3466

  6. Thomas Hohn voted on patch set 1 CR +1 05/20/20, 06:36

  7. Benni Mack commented on patch set 1 V +1 CR +1 05/20/20, 06:50

    unbelievable! thanks!
  8. Helmut Hummel commented on patch set 1 05/20/20, 08:40

    > Patch Set 1: Verified+1 Code-Review+1 > > unbelievable! thanks! I have a talent running into such bugs, when I'm doing something totally different ;)
  9. Helmut Hummel voted on patch set 1 V +2 CR +2 05/20/20, 08:40

  10. Helmut Hummel merged patch set 2 05/20/20, 08:41