Review main Merged

64554[TASK] Improve descriptions of the rootline related methods

Tymoteusz Motylewski CR +2 V +2 Easy +2 −2 updated 05/21/20, 20:31

Commit message

To highlight difference between BackendUtility::BEgetRootLine()
and RootlineUtility->get()

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Tymoteusz Motylewski uploaded patch set 1 05/19/20, 22:19

  2. TYPO3com voted on patch set 1 V +1 05/19/20, 22:30 Completed build in 11m 24s on Tue, 19 May, 10:30 PM Test Summary: 73799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3467

  3. Tymoteusz Motylewski updated the commit message in patch set 2 05/20/20, 21:10

  4. TYPO3com voted on patch set 2 V +1 05/20/20, 21:22 Completed build in 11m 48s on Wed, 20 May, 09:22 PM Test Summary: 73799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3474

  5. Richard Haeser voted on patch set 2 V +1 CR +1 05/21/20, 05:52

  6. Daniel Goerz commented on patch set 3 05/21/20, 16:19

    Published edit on patch set 2.
  7. Daniel Goerz voted on patch set 3 V +1 CR +1 05/21/20, 16:19

  8. TYPO3com voted on patch set 3 V +1 05/21/20, 16:30 Completed build in 11m 15s on Thu, 21 May, 04:30 PM Test Summary: 73803 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3480

  9. Oliver Klee commented on patch set 3 CR +1 05/21/20, 19:22

    <3
  10. Richard Haeser voted on patch set 3 V +2 CR +2 05/21/20, 20:31

  11. Richard Haeser merged patch set 4 05/21/20, 20:31