64557[TASK] Cover BackendUserAuthentication->returnWebmounts() with test
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Richard Haeser +1
- Andreas Kienast +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Richard Haeser +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+2 −3
- typo3/sysext/core/Tests/Functional/Authentication/Fixtures/be_groups.xml+1 −1
- typo3/sysext/core/Tests/Functional/Authentication/Fixtures/pages.xml+42 −0
- typo3/sysext/core/Tests/Functional/Authentication/BackendUserAuthenticationTest.php2+14 −0
Review log 1216
-
Tymoteusz Motylewski uploaded patch set 1 05/20/20, 21:00
-
TYPO3com voted on patch set 1 V -1 05/20/20, 21:01 Completed build in 22s on Wed, 20 May, 09:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3472
-
Tymoteusz Motylewski uploaded patch set 2 05/20/20, 21:01
-
TYPO3com voted on patch set 2 V -1 05/20/20, 21:13 Completed build in 11m 33s on Wed, 20 May, 09:13 PM Test Summary: 1 of 74287 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3473
-
TYPO3com voted on patch set 2 V +1 05/21/20, 05:37 Completed build in 11m 02s on Thu, 21 May, 05:37 AM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3476
-
Richard Haeser voted on patch set 2 V +1 CR +1 05/21/20, 05:51
-
Andreas Kienast commented on patch set 2 05/21/20, 10:32
-
Benni Mack commented on patch set 2 05/22/20, 08:38
BackendUserAuthentication.php:1258any reason you wanted to remove this comment? I think it's valuable -
Tymoteusz Motylewski commented on patch set 2 05/23/20, 14:21
BackendUserAuthentication.php:1258Reply UnresolvedBecause its completely wrong. Please check the tests, they are showing that neither deleted records nor one user has no permissions are returned by this function. See fetchcgroupdata() This comment gave me some pain when working on the page tree stuff :) -
Tymoteusz Motylewski uploaded patch set 3 05/23/20, 14:33
-
Tymoteusz Motylewski commented on patch set 3 05/23/20, 14:34
pushed new patchet with additional assertion covering non-root level db mountBackendUserAuthenticationTest.php:100ReplyDone -
TYPO3com voted on patch set 3 V +1 05/23/20, 14:45 Completed build in 11m 28s on Sat, 23 May, 02:45 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3499
-
Andreas Kienast voted on patch set 3 V +1 CR +1 05/24/20, 09:28
-
Richard Haeser voted on patch set 3 V +1 CR +1 05/24/20, 11:54
-
Tymoteusz Motylewski commented on patch set 3 V +2 CR +2 05/25/20, 15:15
have enough votes -
Tymoteusz Motylewski merged patch set 4 05/25/20, 15:15
BackendUserAuthenticationTest.php:100