Review main Merged

64557[TASK] Cover BackendUserAuthentication->returnWebmounts() with test

Tymoteusz Motylewski CR +2 V +2 Normal +59 −4 updated 05/25/20, 15:15

Commit message

Also fix misleading comment about permissions.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Richard Haeser +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1216

  1. Tymoteusz Motylewski uploaded patch set 1 05/20/20, 21:00

  2. TYPO3com voted on patch set 1 V -1 05/20/20, 21:01 Completed build in 22s on Wed, 20 May, 09:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3472

  3. Tymoteusz Motylewski uploaded patch set 2 05/20/20, 21:01

  4. TYPO3com voted on patch set 2 V -1 05/20/20, 21:13 Completed build in 11m 33s on Wed, 20 May, 09:13 PM Test Summary: 1 of 74287 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3473

  5. TYPO3com voted on patch set 2 V +1 05/21/20, 05:37 Completed build in 11m 02s on Thu, 21 May, 05:37 AM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3476

  6. Richard Haeser voted on patch set 2 V +1 CR +1 05/21/20, 05:51

  7. Andreas Kienast commented on patch set 2 05/21/20, 10:32

    BackendUserAuthenticationTest.php:100

    May we check nested pages as well, for example a subpage of uid=4 with proper permissions?
  8. Benni Mack commented on patch set 2 05/22/20, 08:38

    BackendUserAuthentication.php:1258

    any reason you wanted to remove this comment? I think it's valuable
  9. Tymoteusz Motylewski commented on patch set 2 05/23/20, 14:21

    BackendUserAuthentication.php:1258 Reply Unresolved

    Because its completely wrong. Please check the tests, they are showing that neither deleted records nor one user has no permissions are returned by this function. See fetchcgroupdata() This comment gave me some pain when working on the page tree stuff :)
  10. Tymoteusz Motylewski uploaded patch set 3 05/23/20, 14:33

  11. Tymoteusz Motylewski commented on patch set 3 05/23/20, 14:34

    pushed new patchet with additional assertion covering non-root level db mount

    BackendUserAuthenticationTest.php:100 Reply

    Done
  12. TYPO3com voted on patch set 3 V +1 05/23/20, 14:45 Completed build in 11m 28s on Sat, 23 May, 02:45 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3499

  13. Andreas Kienast voted on patch set 3 V +1 CR +1 05/24/20, 09:28

  14. Richard Haeser voted on patch set 3 V +1 CR +1 05/24/20, 11:54

  15. Tymoteusz Motylewski commented on patch set 3 V +2 CR +2 05/25/20, 15:15

    have enough votes
  16. Tymoteusz Motylewski merged patch set 4 05/25/20, 15:15