Review main Merged

64558[TASK] Clean up admin panel types

Susi Moog CR +2 V +2 Easy +13 −7 updated 05/22/20, 13:24

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 89

  1. Susi Moog uploaded patch set 1 05/21/20, 13:35

  2. TYPO3com voted on patch set 1 V +1 05/21/20, 13:46 Completed build in 11m 04s on Thu, 21 May, 01:46 PM Test Summary: 73804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3478

  3. Oliver Klee commented on patch set 1 05/21/20, 14:18

    Events.php:50

    Shouldn't the type hint then use the interface as well?
  4. Susi Moog commented on patch set 1 05/21/20, 15:37

    Events.php:50 Reply

    No, that's configured via services.yaml alias, that's why I need to explicitly annotate it here so the IDE etc. "gets it".
  5. Daniel Goerz voted on patch set 1 V +1 CR +1 05/21/20, 17:21

  6. Oliver Klee commented on patch set 1 05/21/20, 19:22

    Events.php:50 Reply

    Does is matter to the code which class it is? Or would any class implementing the interface do?
  7. Susi Moog commented on patch set 1 05/22/20, 07:13

    Events.php:50 Reply Unresolved

    It does matter as the specific configured implementation has one more method than the default interface (but can't use a separate interface as it is simultaneously used as transparent replacement of other occurences of the same class throughout the core when the extension is installed)
  8. Andreas Kienast voted on patch set 1 V +2 CR +2 05/22/20, 13:23

  9. Andreas Kienast merged patch set 2 05/22/20, 13:24