Review main Merged

64560[BUGFIX] Bring back record type icons for select items

Oli Bartsch CR +2 V +2 Easy +22 −0 updated 05/22/20, 09:34

Commit message

With the removal of `selicon_field_path` in #87937 also the
automatic record type icon mapping was removed.

As a result the record icon of a select item based on `foreign_table`
is not resolved anymore. In addition, the `selectIcons` list is therefore
no longer displayed.

The previous functionality is now restored.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 89

  1. Oli Bartsch uploaded patch set 1 05/21/20, 19:34

  2. TYPO3com voted on patch set 1 V +1 05/21/20, 19:46 Completed build in 11m 21s on Thu, 21 May, 07:46 PM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3481

  3. Markus Klein voted on patch set 1 CR +1 05/21/20, 21:32

  4. Benni Mack voted on patch set 1 V +1 CR +1 05/22/20, 06:50

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 05/22/20, 08:46

  6. Daniel Goerz merged patch set 2 05/22/20, 08:46

  7. Guido Schmechel commented on patch set 2 05/22/20, 08:53

    AbstractItemProvider.php:549

    Shouldn't we also place the instantiation outside the loop? Comparable to the fileRepository
  8. Oli Bartsch commented on patch set 2 05/22/20, 09:31

    AbstractItemProvider.php:549 Reply

    You are totally right. I wanted to avoid initialization if not needed but to initialize on every iteration is no benefit. Please have a look: Please have a look: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64561
  9. Guido Schmechel commented on patch set 2 05/22/20, 09:34

    AbstractItemProvider.php:549 Reply Unresolved

    Sorry for nitpicking, but thanks for your understanding!