64560[BUGFIX] Bring back record type icons for select items
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Markus Klein +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 89
-
Oli Bartsch uploaded patch set 1 05/21/20, 19:34
-
TYPO3com voted on patch set 1 V +1 05/21/20, 19:46 Completed build in 11m 21s on Thu, 21 May, 07:46 PM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3481
-
Markus Klein voted on patch set 1 CR +1 05/21/20, 21:32
-
Benni Mack voted on patch set 1 V +1 CR +1 05/22/20, 06:50
-
Daniel Goerz voted on patch set 1 V +2 CR +2 05/22/20, 08:46
-
Daniel Goerz merged patch set 2 05/22/20, 08:46
-
Guido Schmechel commented on patch set 2 05/22/20, 08:53
-
Oli Bartsch commented on patch set 2 05/22/20, 09:31
AbstractItemProvider.php:549ReplyYou are totally right. I wanted to avoid initialization if not needed but to initialize on every iteration is no benefit. Please have a look: Please have a look: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64561 -
Guido Schmechel commented on patch set 2 05/22/20, 09:34
AbstractItemProvider.php:549Reply UnresolvedSorry for nitpicking, but thanks for your understanding!
AbstractItemProvider.php:549