64561[TASK] Move iconFactory initialization out of loop
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 910
-
Oli Bartsch uploaded patch set 1 05/22/20, 09:27
-
TYPO3com voted on patch set 1 V +1 05/22/20, 09:39 Completed build in 11m 42s on Fri, 22 May, 09:39 AM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3485
-
Benni Mack voted on patch set 1 V +1 CR +1 05/22/20, 09:50
-
Guido Schmechel commented on patch set 1 05/22/20, 10:00
-
Oli Bartsch commented on patch set 1 05/22/20, 10:39
TcaSelectTreeItemsTest.php:124ReplyTBH I just added them again based on the original patch where they were removed. Without, the unit tests fail. Reason seems to be documented in Line 110: "Two instances are needed due to the push/pop behavior of addInstance()" -
Andreas Kienast voted on patch set 1 CR +1 05/22/20, 11:11
-
Oliver Klee voted on patch set 1 CR +1 05/22/20, 11:19
-
Daniel Goerz voted on patch set 1 V +2 CR +2 05/22/20, 11:55
-
Daniel Goerz merged patch set 2 05/22/20, 11:55
-
Guido Schmechel commented on patch set 2 05/22/20, 11:56
TcaSelectTreeItemsTest.php:124Reply UnresolvedThanks for explanation :-)
TcaSelectTreeItemsTest.php:124