Review 9.5 Merged

64563[BUGFIX] Avoid PHP 7.4 notices with nikic/php-parser

Benni Mack CR +2 V +2 Easy +12 −11 updated 05/25/20, 15:30

Commit message

TYPO3 v9 is loaded with nikic/php-parser 4.2.2, however
only 4.3.0 or higher fixed some PHP 7.4 compatibility
issues. For this reason, the dependency is now raised
to use at least v4.3.0.

  composer req nikic/php-parser:^4.3.0

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 913

  1. Benni Mack uploaded patch set 1 05/22/20, 11:06

  2. TYPO3com voted on patch set 1 V +1 05/22/20, 11:21 Completed build in 13m 52s on Fri, 22 May, 11:21 AM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-646

  3. Benni Mack updated the commit message in patch set 2 05/25/20, 12:38

  4. Benni Mack uploaded patch set 3 05/25/20, 12:39

  5. Markus Klein commented on patch set 3 05/25/20, 12:46

    Unresolved

    master is 4.3.0 currently
  6. Benni Mack updated the commit message in patch set 4 05/25/20, 12:50

  7. TYPO3com voted on patch set 2 V +1 05/25/20, 12:57 Completed build in 18m 53s on Mon, 25 May, 12:56 PM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-650

  8. Oliver Klee voted on patch set 4 CR +1 05/25/20, 12:57

  9. TYPO3com voted on patch set 3 V +1 05/25/20, 13:01 Completed build in 21m 46s on Mon, 25 May, 01:01 PM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-651

  10. TYPO3com voted on patch set 4 V +1 05/25/20, 13:08 Completed build in 18m 06s on Mon, 25 May, 01:08 PM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-652

  11. Markus Klein voted on patch set 4 V +1 CR +1 05/25/20, 13:17

  12. Benni Mack voted on patch set 4 V +2 CR +2 05/25/20, 15:30

  13. Benni Mack merged patch set 5 05/25/20, 15:30