64564[BUGFIX] Optimize database pre checks within install process
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Richard Haeser +1
- Jörg Bösche +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/install/Classes/Controller/InstallerController.php10+64 −8
- typo3/sysext/install/Classes/Database/PermissionsCheck.php9new+232 −0
- typo3/sysext/install/Classes/ServiceProvider.php+9 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseSelect.html1+2 −2
- typo3/sysext/install/composer.json+1 −0
Review log 3036
Show 811 earlier messages
-
Frank Nägler uploaded patch set 1 05/22/20, 13:04
-
Frank Nägler uploaded patch set 2 05/22/20, 13:09
-
Mathias Brodala commented on patch set 2 05/22/20, 13:12
-
TYPO3com voted on patch set 1 V +1 05/22/20, 13:16 Completed build in 12m 02s on Fri, 22 May, 01:16 PM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3489
-
TYPO3com voted on patch set 2 V +1 05/22/20, 13:22 Completed build in 12m 32s on Fri, 22 May, 01:22 PM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3490
-
Susi Moog commented on patch set 2 05/22/20, 13:45
hm, I think I'm confused. I have a user with only SELECT priv, which now can choose all the databases but is not allowed to write - this only fails in the last step (with `CREATE command denied to user 'readonly'@'172.18.0.7' for table 'cache_workspaces_cache_tags'` etc) I'm guessing to make sure that the user has all the necessary rights we'd need to do a bit more (or define readonly differently) -
Frank Nägler commented on patch set 2 CR -1 05/22/20, 14:35
on it -
Frank Nägler uploaded patch set 3 05/22/20, 22:19
-
TYPO3com voted on patch set 3 V +1 05/22/20, 22:31 Completed build in 11m 34s on Fri, 22 May, 10:31 PM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3497
-
Oliver Klee commented on patch set 3 05/23/20, 12:34
InstallerController.php:670That we need a comment here is a sign that this code should go into a well-named method (also to keep this overlong method from getting even longer).InstallerController.php:679count returns an integer. This is a condition, though. Can we have something here that returns a boolean, e.g., a comparison with []?InstallerController.php:719UnresolvedDo we know more about the return type, e.g., string[]?PermissionsCheck.php:24UnresolvedThis class needs some documentation on how to use it.PermissionsCheck.php:26@var stringPermissionsCheck.php:27Unresolved@var string[] (I suppose)PermissionsCheck.php:166Unresolved@return string[] (I suppose)PermissionsCheck.php:177UnresolvedThis methods needs documentation what the return value means.PermissionsCheck.php:195UnresolvedDitto. -
Benni Mack updated the commit message in patch set 4 05/25/20, 18:53
-
Frank Nägler commented on patch set 4 05/30/20, 13:55
InstallerController.php:670Replyagree, but not in the scope of this patch. Feel free to create a separate cleanup patch-InstallerController.php:679Reply+1PermissionsCheck.php:26Replynope, the type string is obvious -
Oliver Klee commented on patch set 4 05/30/20, 14:10
InstallerController.php:670ReplyYes, this is part of the scope of this patch. This patch introduces new code, and the new code should be as clean as possible, not make the codebase worse. -
Frank Nägler uploaded patch set 5 05/30/20, 15:06
-
Frank Nägler commented on patch set 5 05/30/20, 15:13
InstallerController.php:670ReplyI do not agree, this is a bugfix that introduces new code to solve a problem we have. The new code is clean and encapsulated into an own class, which will be used in the existing - and not optimal - codebase. Further cleanups in this area could be done in an own issue (TASK) and not with this bugfix patch. More changes as required will possibly break other stuff. Also, we never (or try to prevent) mixing cleanups and bugfixes in one patch. -
TYPO3com voted on patch set 5 V +1 05/30/20, 15:16 Completed build in 10m 30s on Sat, 30 May, 03:16 PM Test Summary: 73034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3698
-
Oliver Klee commented on patch set 5 05/30/20, 15:23
InstallerController.php:670ReplyJust so there is no misunderstanding: We're talking about the new code introduced by this changeset, not about the existing code, right? -
Oliver Klee commented on patch set 5 05/30/20, 16:37
PermissionsCheck.php:26ReplyThe purpose of the annotation in this case is to help static code analysis, e.g., have it complain if something else than a string is written to this field. -
Andreas Kienast commented on patch set 5 06/01/20, 10:04
InstallerController.php:670ReplyIMO it makes little sense to put these seven(!) lines of code into a separate method and leave the rest as is. This should be refactored in another, straight forward patch.PermissionsCheck.php:26Reply UnresolvedThat would be nice if we'd require PHP 7.4 sometime... -
Oliver Klee commented on patch set 5 06/01/20, 10:17
InstallerController.php:670Reply UnresolvedI suggested moving this to a separate method mostly to improve code readability: If a well-named method is called, it's easier to see what happens in the calling method. That the calling method does not get much longer is a nice benefit, but not the main reason for this. -
Oliver Klee commented on patch set 5 06/01/20, 15:49
Just so I'm not misunderstood: I won't block/downvote this patch with the new code added to the existing method. I'm just helping get the changes into the code base in their best possible form. -
Andreas Kienast voted on patch set 5 CR +1 06/05/20, 12:17
-
Tomas Norre Mikkelsen voted on patch set 5 CR +1 06/05/20, 12:31
-
Jörg Bösche voted on patch set 5 CR +1 09/02/20, 10:05
-
Anja Leichsenring commented on patch set 6 09/02/20, 19:45
Published edit on patch set 5. -
Anja Leichsenring voted on patch set 6 CR +1 09/02/20, 19:48
-
TYPO3com voted on patch set 6 V +1 09/02/20, 19:57 Completed build in 11m 49s on Wed, 2 Sep, 07:57 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5155
-
Oliver Klee wrote 09/04/20, 07:43
Removed reviewer Oliver Klee. -
Jörg Bösche voted on patch set 6 CR +1 09/07/20, 08:18
-
Benni Mack updated the commit message in patch set 7 09/07/20, 16:04
-
Benni Mack voted on patch set 7 V +1 CR +1 09/07/20, 16:06
-
TYPO3com voted on patch set 7 V +1 09/07/20, 16:29 Completed build in 23m 04s on Mon, 7 Sep, 04:29 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5335
-
Richard Haeser voted on patch set 7 CR +1 09/07/20, 18:45
-
Jörg Bösche voted on patch set 7 CR +1 09/09/20, 09:07
-
Andreas Kienast voted on patch set 7 V +2 CR +2 09/11/20, 06:49
-
Andreas Kienast merged patch set 8 09/11/20, 06:49
ShowDatabaseSelect.html:40Unresolved