Review main Merged

64568[BUGFIX] Disallow deleting extensions in Composer mode

Andreas Kienast CR +2 V +2 Easy +11 −1 updated 05/25/20, 15:12

Commit message

Deleting an extension in Extension Manager doesn't make much sense in a
Composer-based installation. For this reason, the removal of extensions
is prohibited now.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Simon Gilli +1
    • Markus Klein +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1316

  1. Andreas Kienast uploaded patch set 1 05/24/20, 09:54

  2. TYPO3com voted on patch set 1 V +1 05/24/20, 10:06 Completed build in 11m 08s on Sun, 24 May, 10:05 AM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3502

  3. Oliver Klee voted on patch set 1 CR +1 05/24/20, 10:51

  4. Andreas Kienast updated the commit message in patch set 2 05/24/20, 10:54

  5. Benjamin Franzke commented on patch set 2 V +1 CR -1 05/24/20, 11:02

    ActionController.php:143

    This exception will never be catched. the try block below catches ExtensionManagerException's and created flash messages from these exception – should we rather add a flash message like the catch block does in this case as well? I think an unhandled exception should only be introduced for server errors, and this is not a server error, it's rather a client error/invalid request. We could simply move this lines into the try-block.
  6. TYPO3com voted on patch set 2 V +1 05/24/20, 11:06 Completed build in 11m 12s on Sun, 24 May, 11:06 AM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3503

  7. Benjamin Franzke uploaded patch set 3 1 comment 05/24/20, 11:10

  8. TYPO3com voted on patch set 3 V +1 05/24/20, 11:23 Completed build in 12m 16s on Sun, 24 May, 11:23 AM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3504

  9. Andreas Kienast commented on patch set 3 1 comment 05/25/20, 06:02

  10. Simon Gilli voted on patch set 3 CR +1 05/25/20, 06:35

  11. Mathias Brodala voted on patch set 3 CR +1 05/25/20, 06:40

  12. Oli Bartsch voted on patch set 3 CR +1 05/25/20, 10:06

  13. Oliver Klee voted on patch set 3 CR +1 05/25/20, 13:03

  14. Markus Klein voted on patch set 3 V +1 CR +1 05/25/20, 13:14

  15. Benjamin Franzke commented on patch set 3 V +2 CR +2 05/25/20, 15:12

    ActionController.php:143 Reply

    Moved into the try-block.
  16. Benjamin Franzke merged patch set 4 05/25/20, 15:12