Review main Abandoned

64569[BUGFIX] Correctly return active state of shortcuts

Simon Gilli CR 0 V 0 Normal +67 −7 updated 06/05/20, 14:47

Commit message

The active state of all shortcuts is now calculated depending on the
target's active state. The HMENU takes this in account for shortcut
modes PageRepository::SHORTCUT_MODE_FIRST_SUBPAGE and
PageRepository::SHORTCUT_MODE_RANDOM_SUBPAGE only.

See also https://review.typo3.org/c/Packages/TYPO3.CMS/+/64570 which
solves the issue directly in the HMENU cObject.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 713

  1. Simon Gilli uploaded patch set 1 05/24/20, 13:05

  2. TYPO3com voted on patch set 1 V +1 05/24/20, 13:17 Completed build in 11m 58s on Sun, 24 May, 01:17 PM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3505

  3. Simon Gilli wrote 05/24/20, 14:02

    Topic set to frontend
  4. Simon Gilli updated the commit message in patch set 2 05/24/20, 14:45

  5. Simon Gilli updated the commit message in patch set 3 05/24/20, 14:47

  6. TYPO3com voted on patch set 2 V +1 05/24/20, 14:57 Completed build in 12m 13s on Sun, 24 May, 02:57 PM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3506

  7. TYPO3com voted on patch set 3 V -1 05/24/20, 15:04 Completed build in 16m 55s on Sun, 24 May, 03:04 PM Test Summary: 1 of 74290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3507

  8. TYPO3com voted on patch set 3 V +1 05/24/20, 15:17 Completed build in 11m 03s on Sun, 24 May, 03:17 PM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3508

  9. Benni Mack updated the commit message in patch set 4 05/25/20, 18:53

  10. Simon Gilli updated the commit message in patch set 5 05/26/20, 08:38

  11. TYPO3com voted on patch set 5 V -1 05/26/20, 08:55 Completed build in 16m 15s on Tue, 26 May, 08:55 AM Test Summary: 1 of 74296 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3554

  12. TYPO3com voted on patch set 5 V +1 05/26/20, 17:19 Completed build in 8h 56m 17s on Tue, 26 May, 05:19 PM Test Summary: 73807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3554

  13. Simon Gilli abandoned the change 06/05/20, 14:47

    Abandoned in favour of 64570