Review main Abandoned

64570[WIP][BUGFIX] Correctly return active state of shortcuts

Simon Gilli CR 0 V 0 Normal +168 −3 updated 12/03/21, 08:15

Commit message

The HMENU now calculates the active state of shortcuts with shortcut
modes PageRepository::SHORTCUT_MODE_FIRST_SUBPAGE and
PageRepository::SHORTCUT_MODE_RANDOM_SUBPAGE depending on the target's
active state.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 2431

Show 46 earlier messages
  1. Simon Gilli uploaded patch set 1 05/25/20, 06:13

  2. Simon Gilli wrote 05/25/20, 06:13

    Topic set to frontend
  3. TYPO3com voted on patch set 1 V +1 05/25/20, 06:26 Completed build in 13m 02s on Mon, 25 May, 06:26 AM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3509

  4. Benni Mack updated the commit message in patch set 2 05/25/20, 18:53

  5. Simon Gilli updated the commit message in patch set 3 05/26/20, 08:37

  6. TYPO3com voted on patch set 3 V +1 05/26/20, 08:49 Completed build in 12m 16s on Tue, 26 May, 08:49 AM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3553

  1. Benni Mack commented on patch set 3 06/03/20, 08:06

    AbstractMenuContentObject.php:1695

    do we need to typecast 'doktype' to int?
  2. Simon Gilli commented on patch set 3 06/05/20, 14:46

    AbstractMenuContentObject.php:1695 Reply

    No sure, afaik this should always be an int or isn't it?
  3. Simon Gilli uploaded patch set 4 06/05/20, 19:09

  4. Simon Gilli commented on patch set 4 06/05/20, 19:13

    AbstractMenuContentObject.php:1695 Reply

    Checked the rest of the code and yes doktype and shortcut_mode are always type casted explicit so I also did this now for my change.
  5. TYPO3com voted on patch set 4 V +1 06/05/20, 19:20 Completed build in 11m 23s on Fri, 5 Jun, 07:20 PM Test Summary: 72800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3873

  6. Markus Klein commented on patch set 4 06/19/20, 09:19

    AbstractMenuContentObject.php:1691

    typehint?
  7. Simon Gilli uploaded patch set 5 07/02/20, 08:27

  8. Simon Gilli commented on patch set 5 07/02/20, 08:31

    AbstractMenuContentObject.php:1691 Reply

    Done
  9. TYPO3com voted on patch set 5 V +1 07/02/20, 08:39 Completed build in 11m 21s on Thu, 2 Jul, 08:38 AM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4030

  10. Markus Klein commented on patch set 5 07/02/20, 12:58

    AbstractMenuContentObject.php:1699

    Why this in_array check? We have a switch with the same conditions below anyways
  11. Simon Gilli uploaded patch set 6 07/02/20, 14:29

  12. Simon Gilli commented on patch set 6 07/02/20, 14:31

    AbstractMenuContentObject.php:1699 Reply

    Probably a copy & paste error from the solution found at forge on which this fix is based on ;)
  13. TYPO3com voted on patch set 6 V +1 07/02/20, 14:41 Completed build in 12m 04s on Thu, 2 Jul, 02:41 PM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4033

  14. Markus Klein commented on patch set 6 07/02/20, 16:54

    AbstractMenuContentObject.php:1736

    Reading this again, I would say: If the page is NOT a shortcut, the behaviour of ACT is not changed to be isActive || isCurrent, which means that a page is ACT and CUR at the same time, right? I understood that the isCurrent()-check must only be executed for shortcuts.
  15. Simon Gilli commented on patch set 6 07/03/20, 06:44

    AbstractMenuContentObject.php:1736 Reply Unresolved

    I guess you are right here, will check it again. And perhaps I'm also able to include this cases to tests...
  16. Simon Gilli uploaded patch set 7 08/05/20, 10:00

  17. TYPO3com voted on patch set 7 V -1 08/05/20, 10:12 Completed build in 11m 20s on Wed, 5 Aug, 10:11 AM Test Summary: 30 of 73471 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4415

  18. Simon Gilli marked it work in progress 08/05/20, 11:10

  19. Simon Gilli rebased onto patch set 8 12/06/20, 14:51

  20. TYPO3com voted on patch set 8 V -1 12/06/20, 15:00 Completed build in 09m 16s on Sun, 6 Dec, 03:00 PM Test Summary: 10 of 32664 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7860

  21. Markus Klein commented on patch set 8 12/06/20, 18:08

    Just a question: Do the tests include a case where we have nested shortcuts? so page A (first subpage) points to B (first subpage) points to C?
  22. Benni Mack commented on patch set 8 09/22/21, 16:23

    Unresolved

    What's the status here?
  23. Benni Mack wrote 11/29/21, 10:08

    Change destination moved from master to main
  24. Benni Mack updated the commit message in patch set 9 11/29/21, 13:28

  25. Benni Mack abandoned the change 12/03/21, 08:15

    no updates, abandoning this change for the time being