Review main Abandoned

64571[BUGFIX] Fix install tool updates of user configuration on PostgreSQL

Stephan Großberndt CR 0 V 0 Easy +3 −13 updated 08/03/20, 13:14

Commit message

This patch fixes DBAL-DriverExceptions on PostgreSQL for updates of the
user configuration by defining the correct parameter type for strings
containing NULL bytes in the update queries.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1219

  1. Stephan Großberndt uploaded patch set 1 05/25/20, 15:59

  2. Stephan Großberndt updated the commit message in patch set 2 05/25/20, 16:08

  3. TYPO3com voted on patch set 1 V +1 05/25/20, 16:11 Completed build in 11m 16s on Mon, 25 May, 04:11 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3513

  4. Stephan Großberndt uploaded patch set 3 05/25/20, 16:15

  5. TYPO3com voted on patch set 2 V +1 05/25/20, 16:20 Completed build in 12m 12s on Mon, 25 May, 04:20 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3514

  6. TYPO3com voted on patch set 3 V +1 05/25/20, 16:27 Completed build in 11m 41s on Mon, 25 May, 04:27 PM Test Summary: 73807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3515

  7. Stephan Großberndt uploaded patch set 4 05/25/20, 16:35

  8. TYPO3com voted on patch set 4 V -1 05/25/20, 16:48 Completed build in 13m 18s on Mon, 25 May, 04:48 PM Test Summary: 1 of 74293 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3516

  9. TYPO3com voted on patch set 4 V +1 05/25/20, 17:30 Completed build in 1h 09m 03s on Mon, 25 May, 05:30 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3516

  10. Benni Mack updated the commit message in patch set 5 05/25/20, 18:54

  11. Manuel Selbach commented on patch set 5 05/28/20, 11:49

    BackendUserStartModuleUpdate.php:124

    Is it possible to use `$queryBuilder->createNamedParameter()` here to define the type? e.g. ->set('uc', $queryBuilder->createNamedParameter(serialize($userConfig), \PDO::PARAM_LOB))
  12. TYPO3com voted on patch set 5 V -1 05/28/20, 12:15 Completed build in 37m 14s on Thu, 28 May, 12:15 PM Test Summary: 1 of 74197 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3611

  13. Stephan Großberndt commented on patch set 5 05/28/20, 12:28

    BackendUserStartModuleUpdate.php:124 Reply

    Would be possible, but only for v10, not for v9, there that parameter is not available. Using a querybuilder is unnecessary overhead here: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Database/Connection/Index.html
  14. TYPO3com voted on patch set 5 V +1 05/28/20, 13:13 Completed build in 2h 12m 55s on Thu, 28 May, 01:13 PM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3611

  15. Manuel Selbach commented on patch set 5 05/28/20, 13:32

    BackendUserStartModuleUpdate.php:124 Reply

    What kind of parameter is not available in v9? \PDO::PARAM_LOB is not related to the TYPO3 version AFAIK. I'm not judging whether it is unnecessary overhead or not. It's more a matter of taste, right? From the perspective of reading the query, it is way more obvious to follow the queryBuilder approach from, my point of view.
  16. Stephan Großberndt commented on patch set 5 05/28/20, 13:44

    BackendUserStartModuleUpdate.php:124 Reply

    You added that feature to pass the type as fourth argument to QueryBuilder->set() in https://review.typo3.org/c/Packages/TYPO3.CMS/+/61327, but that is not available in v9
  17. Manuel Selbach commented on patch set 5 05/28/20, 14:03

    BackendUserStartModuleUpdate.php:124 Reply

    ok, if you would use it that way, yes, true. The approach I described here is a bit different (but, yes, I missed the 3rd parameter). May I ask you to have a closer look at the example? ->set('uc', $queryBuilder->createNamedParameter(serialize($userConfig), \PDO::PARAM_LOB), false) This one should also be possible to be used with v9 ;)
  18. Stephan Großberndt abandoned the change 08/03/20, 12:36

    Abandoned for master as these wizards have been removed from master, still valid for 10.4 and 9.5
  19. Stephan Großberndt commented on patch set 5 08/03/20, 13:14

    BackendUserStartModuleUpdate.php:124 Reply

    I'd rather have used my time for something more valuable and I still think using querybuilder is unnecessary overhead here, but there you go, Manuel. I abandoned this change and updated the 10.4 backport https://review.typo3.org/c/Packages/TYPO3.CMS/+/64541 and 9.5 backport https://review.typo3.org/c/Packages/TYPO3.CMS/+/64572 and am looking forward to your positive reviews and verifications.