Review main Merged

64577[BUGFIX] Add sites folder to install tool permission check

Stephan Großberndt CR +2 V +2 Easy +22 −5 updated 08/04/20, 18:38

Commit message

This patch adds the directory `typo3conf/sites/` and for composer based
installs `config/sites/` to the directory status check in the install
tool.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Haupt +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1419

  1. Stephan Großberndt uploaded patch set 1 05/26/20, 09:50

  2. TYPO3com voted on patch set 1 V -1 05/26/20, 10:13 Completed build in 15m 20s on Tue, 26 May, 10:13 AM Test Summary: 3 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3558

  3. Stephan Großberndt rebased onto patch set 2 05/26/20, 13:23

  4. TYPO3com voted on patch set 2 V +1 05/26/20, 16:56 Completed build in 44m 17s on Tue, 26 May, 04:55 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3563

  5. TYPO3com voted on patch set 1 V +1 05/26/20, 17:44 Completed build in 8h 02m 31s on Tue, 26 May, 05:44 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3558

  6. Simon Gilli commented on patch set 2 CR -1 05/27/20, 06:41

    DefaultFactory.php:195

    Similar change (config/sites) should be added here too for composer installs.
  7. Stephan Großberndt commented on patch set 2 05/27/20, 07:24

    DefaultFactory.php:195 Reply

    Please update the patch accordingly.
  8. Simon Gilli uploaded patch set 3 06/05/20, 20:14

  9. Simon Gilli commented on patch set 3 V +1 CR +1 06/05/20, 20:15

    DefaultFactory.php:195 Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 06/05/20, 20:31 Completed build in 16m 16s on Fri, 5 Jun, 08:31 PM Test Summary: 72800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3874

  11. Stephan Großberndt commented on patch set 3 06/06/20, 10:49

    Thank you! :)
  12. Christian Kuhn commented on patch set 3 08/04/20, 14:48

    Looks good to me. However, let's drop 9.5 - I'd say this is not a priority fix.
  13. Christian Kuhn uploaded patch set 4 08/04/20, 14:48

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 08/04/20, 14:49

  15. TYPO3com voted on patch set 4 V +1 08/04/20, 14:59 Completed build in 10m 49s on Tue, 4 Aug, 02:59 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4402

  16. Stephan Großberndt commented on patch set 4 08/04/20, 15:06

    Ok. Thanks for the review.
  17. Daniel Haupt voted on patch set 4 CR +1 08/04/20, 15:20

  18. Anja Leichsenring voted on patch set 4 V +2 CR +2 08/04/20, 18:37

  19. Anja Leichsenring merged patch set 5 08/04/20, 18:38