Review main Merged Breaking

64578[!!!][TASK] Remove deprecated Signals from SignalSlot Dispatcher

Benni Mack CR +2 V +2 Nightmare +232 −2352 updated 05/26/20, 17:42

Commit message

This change removes all triggers ("SlotReplacement classes") to Signals
that were used until TYPO3 v10 LTS.

The SignalSlot Dispatcher still stay for the time being, but it is unused in
TYPO3 Core now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 33

Show 13 more files

Review log 814

  1. Benni Mack uploaded patch set 1 05/26/20, 10:58

  2. Wouter Wolters voted on patch set 1 CR +1 05/26/20, 12:08

  3. Benni Mack updated the commit message in patch set 2 05/26/20, 14:21

  4. Benni Mack rebased onto patch set 3 05/26/20, 14:41

  5. TYPO3com voted on patch set 2 V -1 05/26/20, 16:48 Completed build in 36m 24s on Tue, 26 May, 04:48 PM Test Summary: 1 of 74296 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3565

  6. TYPO3com voted on patch set 1 V +1 05/26/20, 17:02 Completed build in 50m 48s on Tue, 26 May, 05:02 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3562

  7. TYPO3com voted on patch set 1 V -1 05/26/20, 17:12 Completed build in 1h 00m 37s on Tue, 26 May, 05:12 PM Test Summary: 1 of 74295 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3559

  8. TYPO3com voted on patch set 2 V +1 05/26/20, 17:16 Completed build in 1h 41m 24s on Tue, 26 May, 05:16 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3565

  9. TYPO3com voted on patch set 3 V +1 05/26/20, 17:17 Completed build in 1h 06m 15s on Tue, 26 May, 05:17 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3566

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 05/26/20, 17:23

  11. Wouter Wolters voted on patch set 3 V +1 CR +1 05/26/20, 17:32

  12. Benni Mack voted on patch set 3 V +2 CR +2 05/26/20, 17:33

  13. Benni Mack merged patch set 4 05/26/20, 17:33

  14. TYPO3com voted on patch set 1 V +1 05/26/20, 17:42 Completed build in 2h 32m 00s on Tue, 26 May, 05:42 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3559