Review main Merged Breaking

64583[!!!][TASK] Remove deprecated TSFE hooks and output functionality

Benni Mack CR +2 V +2 Normal +30 −145 updated 05/26/20, 18:58

Commit message

This change removes deprecated hooks and methods from TSFE
related to output:

* TSFE->isOutputting()
* TSFE->processContentForOutput()
* TSFE->settingLocale()
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_eofe']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['pageIndexing']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['isOutputting']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-contentStrReplace']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-output']

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 711

  1. Benni Mack uploaded patch set 1 05/26/20, 14:41

  2. TYPO3com voted on patch set 1 V -1 05/26/20, 16:13 Completed build in 01m 34s on Tue, 26 May, 04:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3567

  3. Benni Mack rebased onto patch set 2 05/26/20, 17:34

  4. Wouter Wolters commented on patch set 2 CR -1 05/26/20, 17:40

    TypoScriptFrontendController.php:2851 Unresolved

    target
  5. Wouter Wolters uploaded patch set 3 05/26/20, 17:42

  6. Wouter Wolters voted on patch set 3 V +1 CR +1 05/26/20, 17:51

  7. TYPO3com voted on patch set 2 V +1 05/26/20, 18:17 Completed build in 32m 25s on Tue, 26 May, 06:17 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3575

  8. TYPO3com commented on patch set 2 05/26/20, 18:24 Completed build in 38m 49s on Tue, 26 May, 06:24 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3576

  9. TYPO3com voted on patch set 3 V +1 05/26/20, 18:31 Completed build in 38m 14s on Tue, 26 May, 06:31 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3577

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 05/26/20, 18:57

  11. Anja Leichsenring merged patch set 4 05/26/20, 18:58