Review main Merged Breaking

64584[!!!][TASK] Remove deprecated constants and runtime activated packages

Benni Mack CR +2 V +2 Normal +30 −178 updated 05/27/20, 09:10

Commit message

This change removes the unneeded public constants

- FILE_DENY_PATTERN_DEFAULT
- PHP_EXTENSIONS_DEFAULT
- TYPO3_copyright_year
- TYPO3_URL_DONATE
- TYPO3_URL_EXCEPTION
- TYPO3_URL_GENERAL
- TYPO3_URL_LICENSE
- TYPO3_URL_WIKI_OPCODECACHE

as well as the runtimeActivatedPackages feature, all of which have
been marked as deprecated in TYPO3 v10.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 7

Review log 1014

  1. Benni Mack uploaded patch set 1 05/26/20, 14:41

  2. TYPO3com voted on patch set 1 V -1 05/26/20, 16:13 Completed build in 01m 43s on Tue, 26 May, 04:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3568

  3. Benni Mack rebased onto patch set 2 05/26/20, 19:00

  4. TYPO3com voted on patch set 2 V -1 05/26/20, 19:00 Completed build in 22s on Tue, 26 May, 07:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3580

  5. Benni Mack uploaded patch set 3 05/26/20, 19:44

  6. TYPO3com voted on patch set 3 V -1 05/26/20, 19:59 Completed build in 14m 34s on Tue, 26 May, 07:59 PM Test Summary: 99 of 74295 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3581

  7. Benni Mack uploaded patch set 4 05/26/20, 20:02

  8. TYPO3com voted on patch set 4 V +1 05/26/20, 20:21 Completed build in 17m 07s on Tue, 26 May, 08:21 PM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3584

  9. Anja Leichsenring voted on patch set 4 V +1 CR +1 05/26/20, 20:24

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 05/26/20, 20:30

  11. Benni Mack voted on patch set 4 V +2 CR +2 05/26/20, 20:31

  12. Benni Mack merged patch set 5 05/26/20, 20:31

  13. Benjamin Franzke commented on patch set 5 05/27/20, 06:52

    Post CR -1, I would ask for a bit more time for reviews. From what I see right now there are some remaining places where runtimeActivatesPackages are still taken into account: typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php calculates $GLOBALS['TYPO3_CONF_VARS']['EXT']['runtimeActivatedPackages'] into cache hashes. typo3/sysext/core/Configuration/DefaultConfiguration.php contains the default value. typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php contains logic regarding runtimeActivatedPackages. See: git grep runtimeActivatedPackages | grep -v "/Documentation/\|/ExtensionScanner/"

    Bootstrap.php:111 Unresolved

    As the patch removes PackageManager->activePackageDuringRuntime, the comment would need to be updated to contain "@todo refactor as activePackageDuringRuntime as been removed". Because, like the comment said, setSingletonInstance and setPackageManager was necessary because the packageManager was needed at this point for runtime activated packages, now that they are gone, the bootstrapping can be cleaned up (thats of course fine with another commit, but I would have adapted the comment in this patch)
  14. Benjamin Franzke commented on patch set 5 05/27/20, 09:10