Review main Merged

64588[TASK] Cleanup runtimeActivatedPackages deprecation removal

Benjamin Franzke CR +2 V +2 Easy +11 −15 updated 05/30/20, 10:40

Commit message

Remove a stale comment wrt PackageManager->activePackageDuringRuntime()
as that method has been removed in #91477. Drop the setSingletonInstance
workaround which was only needed for the runtime activated packages
feature to work.

Also remove some left over runtimeActivatedPackages logic in various
places.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 3

Files 5

Review log 710

  1. Benjamin Franzke uploaded patch set 1 05/27/20, 07:19

  2. TYPO3com voted on patch set 1 V -1 05/27/20, 07:33 Completed build in 14m 03s on Wed, 27 May, 07:33 AM Test Summary: 73391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3592

  3. TYPO3com voted on patch set 1 V +1 05/27/20, 08:12 Completed build in 1h 06m 33s on Wed, 27 May, 08:12 AM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3592

  4. Wouter Wolters voted on patch set 1 CR +1 05/27/20, 12:36

  5. Benni Mack commented on patch set 1 CR -1 05/29/20, 20:55

    We also forgot the Check in ExtensionScanner
  6. Benni Mack uploaded patch set 2 05/29/20, 21:33

  7. Benni Mack voted on patch set 2 V +1 CR +1 05/29/20, 21:33

  8. TYPO3com voted on patch set 2 V +1 05/29/20, 21:57 Completed build in 18m 30s on Fri, 29 May, 09:57 PM Test Summary: 73070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3671

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 05/30/20, 10:40

  10. Andreas Kienast merged patch set 3 05/30/20, 10:40