64589[TASK] Switch to json_encode for tx_cms_showpic parameters
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oliver Klee +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1317
-
Oliver Hader uploaded patch set 1 05/27/20, 15:13
-
TYPO3com voted on patch set 1 V +1 05/27/20, 15:29 Completed build in 15m 31s on Wed, 27 May, 03:29 PM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3594
-
Oliver Hader voted on patch set 1 CR -1 05/27/20, 15:37
-
Oliver Hader marked it work in progress 05/27/20, 15:37
-
Oliver Klee commented on patch set 1 05/27/20, 16:31
-
Oliver Hader uploaded patch set 2 05/28/20, 07:08
-
Andreas Kienast commented on patch set 2 05/28/20, 07:08
ContentObjectRenderer.php:1342ReplyThe parameters are appended to a URL. -
Oliver Hader commented on patch set 2 05/28/20, 07:10
This change is ready for review.ContentObjectRenderer.php:1342Reply UnresolvedI've added a comment to the decoding part why it's done like this -
TYPO3com voted on patch set 2 V -1 05/28/20, 07:10 Completed build in 02m 03s on Thu, 28 May, 07:10 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3602
-
TYPO3com commented on patch set 2 05/28/20, 07:40 Completed build in 34m 04s on Thu, 28 May, 07:40 AM Test Summary: 73698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3602
-
TYPO3com voted on patch set 2 V +1 05/28/20, 07:45 Completed build in 1h 11m 19s on Thu, 28 May, 07:45 AM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3602
-
Andreas Kienast voted on patch set 2 CR +1 05/28/20, 10:07
-
Benni Mack voted on patch set 2 CR +1 05/28/20, 10:22
-
Oliver Klee voted on patch set 2 CR +1 05/28/20, 18:16
-
Benni Mack voted on patch set 2 V +1 05/29/20, 21:47
-
Oliver Hader voted on patch set 2 V +2 CR +2 05/30/20, 08:15
-
Oliver Hader merged patch set 3 05/30/20, 08:15
ContentObjectRenderer.php:1342