Review main Merged

64589[TASK] Switch to json_encode for tx_cms_showpic parameters

Oliver Hader CR +2 V +2 Easy +9 −4 updated 05/30/20, 08:15

Commit message

Scalar values sent via HTTP query parameters to ShowImageController
are using `json_encode` instead of `unserialize`. The parameter
stream is still secured with an HMAC before being deserialized.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1317

  1. Oliver Hader uploaded patch set 1 05/27/20, 15:13

  2. TYPO3com voted on patch set 1 V +1 05/27/20, 15:29 Completed build in 15m 31s on Wed, 27 May, 03:29 PM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3594

  3. Oliver Hader voted on patch set 1 CR -1 05/27/20, 15:37

  4. Oliver Hader marked it work in progress 05/27/20, 15:37

  5. Oliver Klee commented on patch set 1 05/27/20, 16:31

    ContentObjectRenderer.php:1342

    Do we still need the base64_encode?
  6. Oliver Hader uploaded patch set 2 05/28/20, 07:08

  7. Andreas Kienast commented on patch set 2 05/28/20, 07:08

    ContentObjectRenderer.php:1342 Reply

    The parameters are appended to a URL.
  8. Oliver Hader commented on patch set 2 05/28/20, 07:10

    This change is ready for review.

    ContentObjectRenderer.php:1342 Reply Unresolved

    I've added a comment to the decoding part why it's done like this
  9. TYPO3com voted on patch set 2 V -1 05/28/20, 07:10 Completed build in 02m 03s on Thu, 28 May, 07:10 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3602

  10. TYPO3com commented on patch set 2 05/28/20, 07:40 Completed build in 34m 04s on Thu, 28 May, 07:40 AM Test Summary: 73698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3602

  11. TYPO3com voted on patch set 2 V +1 05/28/20, 07:45 Completed build in 1h 11m 19s on Thu, 28 May, 07:45 AM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3602

  12. Andreas Kienast voted on patch set 2 CR +1 05/28/20, 10:07

  13. Benni Mack voted on patch set 2 CR +1 05/28/20, 10:22

  14. Oliver Klee voted on patch set 2 CR +1 05/28/20, 18:16

  15. Benni Mack voted on patch set 2 V +1 05/29/20, 21:47

  16. Oliver Hader voted on patch set 2 V +2 CR +2 05/30/20, 08:15

  17. Oliver Hader merged patch set 3 05/30/20, 08:15