64590[BUGFIX] Use hash_equals when comparing cryptographic hash values
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Daniel Haupt +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1012
-
Oliver Hader uploaded patch set 1 05/27/20, 15:31
-
TYPO3com voted on patch set 1 V +1 05/27/20, 15:47 Completed build in 15m 03s on Wed, 27 May, 03:47 PM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3595
-
Oliver Klee commented on patch set 1 05/27/20, 16:30
I like the code change. However, shouldn't this be a BUGFIX? -
Wouter Wolters voted on patch set 1 CR +1 05/27/20, 17:44
-
Oliver Hader commented on patch set 1 05/27/20, 17:55
Reply Unresolved
What's the bug in this case? -
Oliver Hader updated the commit message in patch set 2 05/27/20, 19:06
-
TYPO3com voted on patch set 2 V +1 05/27/20, 19:20 Completed build in 13m 57s on Wed, 27 May, 07:20 PM Test Summary: 73707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3596
-
Oliver Klee voted on patch set 2 CR +1 05/27/20, 20:49
-
Daniel Haupt voted on patch set 2 CR +1 05/28/20, 20:54
-
Benni Mack voted on patch set 2 V +1 CR +1 05/29/20, 10:26
-
Andreas Kienast voted on patch set 2 V +2 CR +2 05/29/20, 10:39
-
Andreas Kienast merged patch set 3 05/29/20, 10:39