Review main Merged Breaking

64593[!!!][TASK] Remove deprecated functionality in GeneralUtility

Benni Mack CR +2 V +2 Hard +50 −665 updated 05/29/20, 10:59

Commit message

The following deprecated methods are now removed:

- \TYPO3\CMS\Core\Utility\GeneralUtility::compressIPv6
- \TYPO3\CMS\Core\Utility\GeneralUtility::flushDirectory
- \TYPO3\CMS\Core\Utility\GeneralUtility::getApplicationContext
- \TYPO3\CMS\Core\Utility\GeneralUtility::idnaEncode
- \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Hex2Bin
- \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Bin2Hex
- \TYPO3\CMS\Core\Utility\GeneralUtility::isRunningOnCgiServerApi
- \TYPO3\CMS\Core\Utility\GeneralUtility::linkThisUrl
- \TYPO3\CMS\Core\Utility\GeneralUtility::milliseconds
- \TYPO3\CMS\Core\Utility\GeneralUtility::presetApplicationContext
- \TYPO3\CMS\Core\Utility\GeneralUtility::resetApplicationContext
- \TYPO3\CMS\Core\Utility\GeneralUtility::verifyFilenameAgainstDenyPattern

In addition, makeInstanceService requires the third parameter to be array
instead of string or array.

The method "getUrl()" now only accepts one argument.

In addition, the testing framework is raised to 6.3.1 to not use
the unneeded methods anymore.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 814

  1. Benni Mack uploaded patch set 1 05/28/20, 09:06

  2. TYPO3com voted on patch set 1 V -1 05/28/20, 09:28 Completed build in 09m 26s on Thu, 28 May, 09:28 AM Test Summary: 10685 of 73461 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3606

  3. Benni Mack uploaded patch set 2 05/28/20, 18:57

  4. TYPO3com voted on patch set 2 V +1 05/28/20, 19:37 Completed build in 39m 45s on Thu, 28 May, 07:37 PM Test Summary: 73064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3614

  5. Andreas Kienast uploaded patch set 3 05/29/20, 08:50

  6. Andreas Kienast voted on patch set 3 V +1 CR +1 05/29/20, 08:51

  7. TYPO3com voted on patch set 3 V -1 05/29/20, 09:12 Completed build in 17m 58s on Fri, 29 May, 09:12 AM Test Summary: 1 of 73560 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3617

  8. TYPO3com commented on patch set 3 05/29/20, 09:17 Completed build in 41m 38s on Fri, 29 May, 09:17 AM Test Summary: 1 of 73560 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3617

  9. TYPO3com commented on patch set 3 05/29/20, 09:37 Completed build in 1h 24m 42s on Fri, 29 May, 09:37 AM Test Summary: 1 of 73560 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3617

  10. Andreas Kienast rebased onto patch set 4 05/29/20, 10:10

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 05/29/20, 10:24

  12. TYPO3com voted on patch set 4 V +1 05/29/20, 10:24 Completed build in 14m 26s on Fri, 29 May, 10:24 AM Test Summary: 73073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3621

  13. Anja Leichsenring voted on patch set 4 V +2 CR +2 05/29/20, 10:59

  14. Anja Leichsenring merged patch set 5 05/29/20, 10:59