Review main Merged Breaking

64595[!!!][TASK] Remove language-related deprecated functionality

Benni Mack CR +2 V +2 Normal +28 −97 updated 05/29/20, 18:58

Commit message

The global variable 'LOCAL_LANG' is now removed, as all labels
should always be fetched via LanguageService.

In addition, the following methods have been removed:
* Locales::initialize()
* LanguageService->getLabelsWithPrefix()

The following public methods and properties have now changed their visibility to protected
* LanguageService->LL_files_cache
* LanguageService->LL_labels_cache
* LanguageService->debugLL()
* LanguageService->getLLL()

The method LanguageService->includeLLFile() now only expects one argument

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 2

Files 9

Review log 913

  1. Benni Mack uploaded patch set 1 05/28/20, 10:21

  2. TYPO3com voted on patch set 1 V -1 05/28/20, 10:47 Completed build in 26m 11s on Thu, 28 May, 10:47 AM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3608

  3. TYPO3com voted on patch set 1 V +1 05/28/20, 13:08 Completed build in 3h 13m 09s on Thu, 28 May, 01:08 PM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3608

  4. Wouter Wolters voted on patch set 1 CR +1 05/29/20, 10:24

  5. Andreas Kienast commented on patch set 1 CR -1 05/29/20, 15:37

    on it
  6. Andreas Kienast uploaded patch set 2 05/29/20, 15:40

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 05/29/20, 15:40

  8. TYPO3com voted on patch set 2 V +1 05/29/20, 15:55 Completed build in 14m 41s on Fri, 29 May, 03:55 PM Test Summary: 73073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3636

  9. Benni Mack uploaded patch set 3 05/29/20, 18:33

  10. Wouter Wolters voted on patch set 3 V +1 CR +1 05/29/20, 18:38

  11. TYPO3com voted on patch set 3 V +1 05/29/20, 18:56 Completed build in 14m 49s on Fri, 29 May, 06:56 PM Test Summary: 73094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3644

  12. Andreas Kienast voted on patch set 3 V +2 CR +2 05/29/20, 18:58

  13. Andreas Kienast merged patch set 4 05/29/20, 18:58