Review main Merged

64596[TASK] Remove legacy font formats

Nikita Hovratov CR +2 V +2 Easy +21 −21 updated 05/31/20, 08:18

Commit message

eot, otf and ttf font formats were used to support very old browsers
like <= IE8. Since TYPO3 v10 does only support modern browsers, these
formats can be safely removed.

Used commands:
>yarn remove npm-font-source-sans-pro
>yarn add source-sans-pro
>grunt build

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 89

Show 69 more files

Review log 1014

  1. Nikita Hovratov uploaded patch set 1 05/28/20, 10:23

  2. TYPO3com voted on patch set 1 V -1 05/28/20, 11:01 Completed build in 23m 37s on Thu, 28 May, 11:01 AM Test Summary: 72086 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3609

  3. Andreas Kienast commented on patch set 1 CR -1 05/28/20, 11:36

    The fonts are installed via yarn, thus the build fails. You have to use another package without these fonts and / or adjust the Gruntfile.
  4. Nikita Hovratov commented on patch set 1 05/28/20, 11:38

    > Patch Set 1: Code-Review-1 > > The fonts are installed via yarn, thus the build fails. You have to use another package without these fonts and / or adjust the Gruntfile. Ah, ok thank you.
  5. TYPO3com commented on patch set 1 05/28/20, 11:41 Completed build in 1h 27m 02s on Thu, 28 May, 11:41 AM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3609

  6. Nikita Hovratov uploaded patch set 2 05/28/20, 13:11

  7. TYPO3com voted on patch set 2 V -1 05/28/20, 13:34 Completed build in 22m 48s on Thu, 28 May, 01:34 PM Test Summary: 2 of 74196 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3612

  8. TYPO3com voted on patch set 2 V +1 05/28/20, 14:42 Completed build in 1h 53m 36s on Thu, 28 May, 02:42 PM Test Summary: 73707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3612

  9. Benni Mack voted on patch set 2 V +1 CR +1 05/29/20, 10:26

  10. Wouter Wolters voted on patch set 2 CR +1 05/29/20, 17:58

  11. Andreas Kienast voted on patch set 2 CR +1 05/30/20, 21:12

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 05/31/20, 05:09

  13. Andreas Kienast merged patch set 3 05/31/20, 05:10

  14. Oliver Hader voted on patch set 3 CR +1 05/31/20, 08:18